Set copt in platform-specific way & increase bazel test timeouts#756
Merged
Conversation
Attempting to use option `--copt=-std=c++17` fails on Windows because the syntax need to be slightly different: `--copt=/std:c++17`. To handle these differences between platforms, we can take advantage of Bazel's `--enable_platform_specific_config` option and define different build configs for Linux, Windows, and Mac.
It seems that `--cxxopt=-D_GLIBCXX_USE_CXX11_ABI=1` works on all platforms (possibly because the Windows compiler ignores altogether?). We may as well pull that out into a single build setting that's common for all platforms.
mhucka
force-pushed
the
mh-bazelrc-platform-specific
branch
from
be04aee to
c039cc1
Compare
On MacOS 13 runners on GitHub, some of the tests fail because they exceed the default timeout.
mhucka
changed the title
dstrain115
approved these changes
Jun 13, 2025
sergeisakov
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to use option
--copt=-std=c++17fails on Windows because the syntax need to be slightly different:--copt=/std:c++17. To handle these differences between platforms, we can take advantage of Bazel's--enable_platform_specific_configoption and define different build configs for Linux, Windows, and Mac.Separately, on MacOS 13 runners on GitHub, a couple of tests failed because they exceeded the default test timeout. This PR increases the timeout.