Further update CMake files#760
Merged
Merged
Conversation
Some version of cmake doesn't like project() begin called at the very start. Changing the order around seems to work better.
On some platforms, the previous pybind-finding code either found the wrong one, or didn't set certain cmake variables.
On MacOS, we need to tell cmake to look in /opt/homebrew for include files and libraries.
This caused the cibuildwheel workflow to fail on GitHub Windows runners.
dstrain115
approved these changes
Jun 13, 2025
sergeisakov
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds more paths for CMake to find include files and libraries on MacOS, fixes a problem with setting
project()in the top-levelDockerfile, and improves and slightly modernizespybind11_interface/GetPybind11.cmake.