Skip to content

Loosen NumPy version requirement to allow version 2 #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhucka merged 3 commits into from
Jun 13, 2025
Merged

Loosen NumPy version requirement to allow version 2 #763

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62c9a1b
Loosen NumPy version requirement to allow version 2
mhucka Jun 12, 2025
948ee43
Add comment to explain the "global" option to pybind11
mhucka Jun 13, 2025
f891b46
Merge branch 'master' into mh-allow-np2
mhucka Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
absl-py
cirq-core~=1.0
numpy~=1.16
numpy>=1.26.0
# The global option to pybind11 makes it include CMake files in a location where
# CMake will find them. It makes a crucial difference in some environments.
pybind11[global]
Copy link
Copy Markdown

@dstrain115 dstrain115 Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the global signify? Is that because we added platform dependent stuff in the other PRs?

Copy link
Copy Markdown
Collaborator Author

@mhucka mhucka Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dstrain115 The global option makes it include pybind11 CMake files in a location accessible from a more standard system location. In addition to going into $VIRTUAL_ENV/lib/python3.9/site-packages/pybind11/share/cmake, it goes into $VIRTUAL_ENV/share/cmake. This makes it possible for CMake to find them on some platforms (I think Windows was the problematic one).

Copy link
Copy Markdown

@dstrain115 dstrain115 Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth a one-line comment to explain this?

Copy link
Copy Markdown
Collaborator Author

@mhucka mhucka Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. I'll do that.

typing_extensions
setuptools
Loading