Suppress CMake version warning coming from Pybind11#789
Merged
Conversation
When building using cibuildwheel, the following warning is printed:
```
CMake Deprecation Warning at .../pybind11-src/CMakeLists.txt:13
(cmake_minimum_required):
Compatibility with CMake < 3.10 will be removed from a future
version of
CMake.
Update the VERSION argument <min> value. Or, use the
<min>...<max> syntax to tell CMake that the project requires
at least <min> but has been updated to work with policies
introduced by <max> or earlier.
```
This is coming from Pybind11's CMake files. We can't do anything about
it, and our devs end up wasting time looking for the cause in qsim's
files.
The change here suppresses deprecation warnings around the part where
Pybind11 is included.
This change should be reverted when Pybind11 updates the minimum
required CMake version to a number that doesn't trigger the warning.
fdmalone
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building using cibuildwheel, the following warning is printed:
The warning is coming from Pybind11's CMake files, not ours. We can't do anything about it, and we end up wasting time looking for the cause in qsim's files.
The change in this PR suppresses deprecation warnings around the part where Pybind11 is included.
This change should be reverted when Pybind11 updates the minimum required CMake version to a number that doesn't trigger the warning.