Make dev_tools/test_libs.sh use Bazel configs for SSE & AVX#795
Merged
Conversation
Although the recent changes made sure not to build & test the versions of files for AVX & SSE on systems that lacked those features, the converse was not done: it did not add `--config=avx` and/or `--config=sse` if the current host supported them. This commit adds the necessary changes to do that.
mhucka
changed the title
Having only one test written in the one-liner style makes it look oddly out of place. Let's use the same style everywhere.
pavoljuhas
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although the recent changes made sure not to build & test the versions of files for AVX & SSE on systems that lacked those features, the converse was not done: it did not add
--config=avxand/or--config=sseif the current host supported them.This commit adds the necessary changes to do that.