Skip to content

Raise correct ValueError on seeing confusion matrix #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavoljuhas merged 2 commits into from
Oct 14, 2025
Merged

Raise correct ValueError on seeing confusion matrix #903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d175349
Raise correct ValueError on seeing confusion matrices
pavoljuhas Oct 13, 2025
4a178d3
No need for any() here
pavoljuhas Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions qsimcirq/qsim_circuit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,13 +374,11 @@ def _check_for_confusion_matrix(self):
for _, op, _ in self.findall_operations_with_gate_type(cirq.MeasurementGate)
if op.gate.confusion_map
]
for confusion_map in confusion_maps_on_measurement_gates:
for map_values in confusion_map.values():
if map_values:
raise ValueError(
"Confusion Matrices are not currently supported in Qsim. "
"See https://github.com/quantumlib/Cirq/issues/6305 for latest status"
)
if confusion_maps_on_measurement_gates:
raise ValueError(
"Confusion Matrices are not currently supported in Qsim. "
"See https://github.com/quantumlib/Cirq/issues/6305 for latest status"
)

def translate_cirq_to_qsim(
self, qubit_order: cirq.QubitOrderOrList = cirq.QubitOrder.DEFAULT
Expand Down
4 changes: 3 additions & 1 deletion qsimcirq_tests/qsimcirq_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,9 @@ def test_confusion_matrix_exception():
x, y = sympy.Symbol("x"), sympy.Symbol("y")
prs = [{x: np.int64(0), y: np.int64(1)}]
qsim_simulator = qsimcirq.QSimSimulator()
with pytest.raises(ValueError):
with pytest.raises(
ValueError, match="Confusion Matrices are not currently supported"
):
_ = qsim_simulator.simulate_sweep(circuit, params=prs)


Expand Down
Loading