fix: status codes lib

Author: rafaelfcardoso

src/controllers/account.controller.ts

@@ -1,26 +1,27 @@
 import { Request, Response, Router } from "express";
 import clientService from "../services/client.service";
 import accountService from "../services/account.service";
+import { StatusCodes } from "http-status-codes";
 
 const accountController = Router();
 
 accountController.get("/:id", async (req: Request, res: Response): Promise<Response> => {
   const codeClient = parseInt(req.params.id);
   const clients = await clientService.getByCodeClient(codeClient);
 
-  return res.status(200).json(clients);
+  return res.status(StatusCodes.OK).json(clients);
 })
 
 accountController.post("/deposito", async (req: Request, res: Response): Promise<Response> => {
   const transaction = await accountService.createDeposit(req.body);
 
-  return res.status(201).json(transaction);
+  return res.status(StatusCodes.CREATED).json(transaction);
 })
 
 accountController.post("/saque", async (req: Request, res: Response): Promise<Response> => {
   const transaction = await accountService.createWithdraw(req.body);
 
-  return res.status(201).json(transaction);
+  return res.status(StatusCodes.CREATED).json(transaction);
 })
 
 export default accountController;

src/controllers/asset.controller.ts

@@ -1,4 +1,5 @@
 import { Request, Response, Router } from "express";
+import { StatusCodes } from "http-status-codes";
 import assetService from "../services/asset.service";
 
 const assetController = Router();
@@ -8,29 +9,29 @@ assetController.get("/:id", async (req: Request, res: Response): Promise<Respons
 
   const assets = await assetService.getByCodeAsset(assetId);
 
-  return res.status(200).json(assets);
+  return res.status(StatusCodes.OK).json(assets);
 })
 
 assetController.get("/cliente/:id", async (req: Request, res: Response): Promise<Response> => {
   const codeClient = parseInt(req.params.id);
 
   const assets = await assetService.getByClient(codeClient);
 
-  return res.status(200).json(assets);
+  return res.status(StatusCodes.OK).json(assets);
 })
 
 assetController.put("/compra/:id", async (req: Request, res: Response): Promise<Response> => {
   const codAtivo = parseInt(req.params.id);
   const order = await assetService.updateBuyOrder(codAtivo, req.body);
 
-  return res.status(200).json(order);
+  return res.status(StatusCodes.OK).json(order);
 })
 
 assetController.put("/venda/:id", async (req: Request, res: Response): Promise<Response> => {
   const codAtivo = parseInt(req.params.id);
   const order = await assetService.updateSellOrder(codAtivo, req.body);
 
-  return res.status(200).json(order);
+  return res.status(StatusCodes.OK).json(order);
 })
 
 export default assetController;

src/controllers/investments.controller.ts

@@ -1,5 +1,6 @@
 import { Request, Response, Router } from 'express';
 // import httpErrorMiddleware from '../middleware/error.middleware';
+import { StatusCodes } from 'http-status-codes';
 import assetService from '../services/asset.service';
 import investmentsService from '../services/investments.service';
 
@@ -13,12 +14,12 @@ investmentController
     const brokerAsset = await assetService.getByCodeAsset(order.codAtivo);
 
     if (brokerAsset.qtdeAtivo < order.qtdeAtivo) {
-      return res.status(400).json({ message: 'Quantidade indisponível!' });
+      return res.status(StatusCodes.BAD_REQUEST).json({ message: 'Quantidade indisponível!' });
     }
 
     const investment = await investmentsService.newBuyOrder(order);
 
-    return res.status(201).json(investment);
+    return res.status(StatusCodes.CREATED).json(investment);
 });
 
 investmentController
@@ -29,9 +30,9 @@ investmentController
 
     if (order.message) {
       console.log(order.message);
-      return res.status(400).json(order.message);
+      return res.status(StatusCodes.BAD_REQUEST).json(order.message);
     } else {
-      return res.status(201).json(investment);
+      return res.status(StatusCodes.CREATED).json(investment);
     }
 }));
 

src/controllers/login.controller.ts

@@ -19,7 +19,7 @@ loginController
 
     const token = generateJWTToken({ codCliente: user.codCliente, username: user.username });
 
-    return res.status(200).json({ token });
+    return res.status(StatusCodes.OK).json({ token });
   });
 
 export default loginController;

src/services/asset.service.ts

@@ -3,6 +3,7 @@ import IClientAsset from "../interfaces/clientAssets.interface";
 import IUpdateOrder from "../interfaces/updateOrder";
 import assetModel from "../models/asset.model";
 import HttpException from "../shared/http.exception";
+import { StatusCodes } from 'http-status-codes';
 
 const isValid = (order: IUpdateOrder) => {
   if (!order.qtdeAtivo || typeof order.qtdeAtivo !== "number") return false;
@@ -21,7 +22,7 @@ const getByClient = (codCliente: number): Promise<IClientAsset[]> => {
 
 const updateBuyOrder = async (codAtivo: number, order: IUpdateOrder): Promise<IUpdateOrder> => {
   if (!isValid(order)) {
-    throw new HttpException(400, "Dados inválidos.");
+    throw new HttpException(StatusCodes.BAD_REQUEST, "Dados inválidos.");
   }
 
   const { valor } = await assetModel.getValueById(codAtivo); // Obtem o valor da acao
@@ -38,15 +39,15 @@ const updateBuyOrder = async (codAtivo: number, order: IUpdateOrder): Promise<IU
       }
     })
   } else {
-    throw new HttpException(400, "Não existem ordens cadastradas neste ativo."); 
+    throw new HttpException(StatusCodes.BAD_REQUEST, "Não existem ordens cadastradas neste ativo."); 
   }
 
   return clientAsset;
 };
 
 const updateSellOrder = async (codAtivo: number, order: IUpdateOrder): Promise<IUpdateOrder>=> {
   if (!isValid(order)) {
-    throw new HttpException(401, "Dados inválidos.");
+    throw new HttpException(StatusCodes.BAD_REQUEST, "Dados inválidos.");
   }
 
   const { valor } = await assetModel.getValueById(codAtivo); // Obtem o valor da acao
@@ -60,13 +61,13 @@ const updateSellOrder = async (codAtivo: number, order: IUpdateOrder): Promise<I
       if (asset.codAtivo === codAtivo) {
 
         if (asset.qtdeAtivo <= order.qtdeAtivo) {
-          throw new HttpException(400, "Valor da venda é maior que a quantia sob custódia.");
+          throw new HttpException(StatusCodes.BAD_REQUEST, "Valor da venda é maior que a quantia sob custódia.");
         }
 
         assetModel.updateSell(clientAsset); // Atualiza a quantia sob custodia 
 
       } else {
-        throw new HttpException(404, `Ativo ${codAtivo} não encontrado para o cliente ${order.codCliente}.`);
+        throw new HttpException(StatusCodes.NOT_FOUND, `Ativo ${codAtivo} não encontrado para o cliente ${order.codCliente}.`);
       }
 
     })

src/services/investments.service.ts

@@ -1,3 +1,4 @@
+import { StatusCodes } from "http-status-codes";
 import IOrderBody from "../interfaces/order.interface";
 import investmentsModel from "../models/investments.model";
 import HttpException from "../shared/http.exception";
@@ -12,7 +13,7 @@ const isValid = (order: IOrderBody) => {
 
 const newBuyOrder = async (order: IOrderBody): Promise<IOrderBody> => {
   if (!isValid(order)) {
-    throw new HttpException(400, "Dados inválidos!");
+    throw new HttpException(StatusCodes.BAD_REQUEST, "Dados inválidos!");
   }
   const { insertId } = await investmentsModel.createBuyOrder(order);
 
@@ -23,7 +24,7 @@ const newBuyOrder = async (order: IOrderBody): Promise<IOrderBody> => {
 
 const newSellOrder = async (order: IOrderBody): Promise<IOrderBody> => {
   if (!isValid(order)) {
-    throw new HttpException(400, "Dados inválidos!");
+    throw new HttpException(StatusCodes.BAD_REQUEST, "Dados inválidos!");
   }
   const { insertId } = await investmentsModel.createSellOrder(order);