Change method of getting json data out of HTTP requests

The requests module has some undercover magic of using a different implementation
depending on whether the simplejson package is installed, which makes the built-in
requests.response.json() method unreliable

To avoid this issue, we are removing all calls to response.json() and parsing the
response using python's built-in json module.

Author: Raphael Lullis

raiden/network/pathfinding.py

@@ -279,21 +279,19 @@ def get_last_iou(
     signature = to_hex(LocalSigner(privkey).sign(signature_data))
 
     try:
-        data = (
-            requests.get(
-                f"{url}/api/v1/{to_checksum_address(token_network_address)}/payment/iou",
-                params=dict(
-                    sender=to_checksum_address(sender),
-                    receiver=to_checksum_address(receiver),
-                    timestamp=timestamp,
-                    signature=signature,
-                ),
-                timeout=DEFAULT_HTTP_REQUEST_TIMEOUT,
-            )
-            .json()
-            .get("last_iou")
+        response = requests.get(
+            f"{url}/api/v1/{to_checksum_address(token_network_address)}/payment/iou",
+            params=dict(
+                sender=to_checksum_address(sender),
+                receiver=to_checksum_address(receiver),
+                timestamp=timestamp,
+                signature=signature,
+            ),
+            timeout=DEFAULT_HTTP_REQUEST_TIMEOUT,
         )
 
+        data = json.loads(response.content).get("last_iou")
+
         if data is None:
             return None
 

raiden/network/resolver/client.py

@@ -1,3 +1,4 @@
+import json
 from http import HTTPStatus
 from typing import TYPE_CHECKING
 
@@ -52,7 +53,7 @@ def reveal_secret_with_resolver(
 
     state_change = ReceiveSecretReveal(
         sender=secret_request_event.recipient,
-        secret=Secret(to_bytes(hexstr=response.json()["secret"])),
+        secret=Secret(to_bytes(hexstr=json.loads(response.content)["secret"])),
     )
     raiden.handle_and_track_state_changes([state_change])
     return True