Set AllowShortLoopsOnASingleLine to false

Author: codereport

.clang-format

@@ -15,7 +15,7 @@ AllowShortBlocksOnASingleLine: true
 AllowShortCaseLabelsOnASingleLine: true
 AllowShortFunctionsOnASingleLine: All
 AllowShortIfStatementsOnASingleLine: true
-AllowShortLoopsOnASingleLine: true
+AllowShortLoopsOnASingleLine: false
 # This is deprecated
 AlwaysBreakAfterDefinitionReturnType: All
 AlwaysBreakAfterReturnType: None

benchmarks/random_allocations/random_allocations.cpp

@@ -232,7 +232,8 @@ BM_RandomAllocations(benchmark::State& state) {
   size_t max_size        = state.range(1);
 
   try {
-    for (auto _ : state) uniform_random_allocations(*mr, num_allocations, max_size, max_usage);
+    for (auto _ : state)
+      uniform_random_allocations(*mr, num_allocations, max_size, max_usage);
   } catch (std::exception const& e) { std::cout << "Error: " << e.what() << "\n"; }
 }
 
@@ -250,7 +251,8 @@ size_range(benchmark::internal::Benchmark* b, int num) {
 
 static void
 num_size_range(benchmark::internal::Benchmark* b) {
-  for (int num_allocations : std::vector<int>{1000, 10000, 100000}) size_range(b, num_allocations);
+  for (int num_allocations : std::vector<int>{1000, 10000, 100000})
+    size_range(b, num_allocations);
 }
 
 int num_allocations = -1;

benchmarks/replay/cxxopts.hpp

@@ -114,7 +114,9 @@ stringAppend(String& s, String a) {
 
 inline String&
 stringAppend(String& s, int n, UChar32 c) {
-  for (int i = 0; i != n; ++i) { s.append(c); }
+  for (int i = 0; i != n; ++i) {
+    s.append(c);
+  }
 
   return s;
 }
@@ -1556,7 +1558,9 @@ Options::generate_all_groups_help(String& result) const {
   std::vector<std::string> all_groups;
   all_groups.reserve(m_help.size());
 
-  for (auto& group : m_help) { all_groups.push_back(group.first); }
+  for (auto& group : m_help) {
+    all_groups.push_back(group.first);
+  }
 
   generate_group_help(result, all_groups);
 }

benchmarks/replay/rapidcsv.h

@@ -1073,7 +1073,9 @@ class Document {
     if ((mLabelParams.mRowNameIdx >= 0) &&
         (static_cast<ssize_t>(mData.size()) > (mLabelParams.mColumnNameIdx + 1))) {
       int i = 0;
-      for (auto& dataRow : mData) { mRowNames[dataRow[mLabelParams.mRowNameIdx]] = i++; }
+      for (auto& dataRow : mData) {
+        mRowNames[dataRow[mLabelParams.mRowNameIdx]] = i++;
+      }
     }
   }
 

benchmarks/test/test_benchmark.cpp

@@ -2,7 +2,8 @@
 
 static void
 BM_StringCreation(benchmark::State& state) {
-  for (auto _ : state) std::string empty_string;
+  for (auto _ : state)
+    std::string empty_string;
 }
 // Register the function as a benchmark
 BENCHMARK(BM_StringCreation);
@@ -11,15 +12,18 @@ BENCHMARK(BM_StringCreation);
 static void
 BM_StringCopy(benchmark::State& state) {
   std::string x = "hello";
-  for (auto _ : state) std::string copy(x);
+  for (auto _ : state)
+    std::string copy(x);
 }
 BENCHMARK(BM_StringCopy);
 
 static void
 BM_StringCompare(benchmark::State& state) {
   std::string s1(state.range(0), '-');
   std::string s2(state.range(0), '-');
-  for (auto _ : state) { benchmark::DoNotOptimize(s1.compare(s2)); }
+  for (auto _ : state) {
+    benchmark::DoNotOptimize(s1.compare(s2));
+  }
   state.SetComplexityN(state.range(0));
 }
 BENCHMARK(BM_StringCompare)->RangeMultiplier(2)->Range(1 << 10, 1 << 18)->Complexity(benchmark::oN);
@@ -30,7 +34,8 @@ BM_Sequential(benchmark::State& state) {
   Q q;
   typename Q::value_type v(0);
   for (auto _ : state) {
-    for (int i = state.range(0); i--;) q.push_back(v);
+    for (int i = state.range(0); i--;)
+      q.push_back(v);
   }
   // actually messages, not bytes:
   state.SetBytesProcessed(static_cast<int64_t>(state.iterations()) * state.range(0));