From 4c5b308ced15c6ae8f875ed991168e99315b8e21 Mon Sep 17 00:00:00 2001 From: Dave Stevenson Date: Tue, 12 Mar 2024 16:10:37 +0000 Subject: [PATCH] dtoverlays: Fixup pendown gpio polarity for ads7846 users The driver has been converted to use gpiod, which will normalise polarity based on DT. The piscreen overlay (and others) incorrectly defines the pendown GPIO as being ACTIVE_HIGH (0), althought triggering on the high-low edge for pen down. It therefore tries reading the pen position when not being touched, and stops when it is touched. Tested with piscreen and ads7846 overlays. Also fixed on others where the interrupt says high->low but the polarity was ACTIVE_HIGH. Signed-off-by: Dave Stevenson --- arch/arm/boot/dts/overlays/ads7846-overlay.dts | 2 +- arch/arm/boot/dts/overlays/hy28a-overlay.dts | 2 +- arch/arm/boot/dts/overlays/hy28b-2017-overlay.dts | 2 +- arch/arm/boot/dts/overlays/hy28b-overlay.dts | 2 +- arch/arm/boot/dts/overlays/mz61581-overlay.dts | 2 +- arch/arm/boot/dts/overlays/piscreen-overlay.dts | 2 +- arch/arm/boot/dts/overlays/piscreen2r-overlay.dts | 2 +- arch/arm/boot/dts/overlays/tinylcd35-overlay.dts | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot/dts/overlays/ads7846-overlay.dts b/arch/arm/boot/dts/overlays/ads7846-overlay.dts index 1c5c9b6bb6ffd7..211a002c0b3447 100644 --- a/arch/arm/boot/dts/overlays/ads7846-overlay.dts +++ b/arch/arm/boot/dts/overlays/ads7846-overlay.dts @@ -57,7 +57,7 @@ spi-max-frequency = <2000000>; interrupts = <255 2>; /* high-to-low edge triggered */ interrupt-parent = <&gpio>; - pendown-gpio = <&gpio 255 0>; + pendown-gpio = <&gpio 255 1>; /* driver defaults */ ti,x-min = /bits/ 16 <0>; diff --git a/arch/arm/boot/dts/overlays/hy28a-overlay.dts b/arch/arm/boot/dts/overlays/hy28a-overlay.dts index 5843a5e9c86a44..d0d52ebd9bd542 100644 --- a/arch/arm/boot/dts/overlays/hy28a-overlay.dts +++ b/arch/arm/boot/dts/overlays/hy28a-overlay.dts @@ -73,7 +73,7 @@ spi-max-frequency = <2000000>; interrupts = <17 2>; /* high-to-low edge triggered */ interrupt-parent = <&gpio>; - pendown-gpio = <&gpio 17 0>; + pendown-gpio = <&gpio 17 1>; ti,x-plate-ohms = /bits/ 16 <100>; ti,pressure-max = /bits/ 16 <255>; }; diff --git a/arch/arm/boot/dts/overlays/hy28b-2017-overlay.dts b/arch/arm/boot/dts/overlays/hy28b-2017-overlay.dts index 95bfb1eadc2088..9df33c5d95bbc9 100644 --- a/arch/arm/boot/dts/overlays/hy28b-2017-overlay.dts +++ b/arch/arm/boot/dts/overlays/hy28b-2017-overlay.dts @@ -132,7 +132,7 @@ spi-max-frequency = <2000000>; interrupts = <17 2>; /* high-to-low edge triggered */ interrupt-parent = <&gpio>; - pendown-gpio = <&gpio 17 0>; + pendown-gpio = <&gpio 17 1>; ti,x-plate-ohms = /bits/ 16 <100>; ti,pressure-max = /bits/ 16 <255>; }; diff --git a/arch/arm/boot/dts/overlays/hy28b-overlay.dts b/arch/arm/boot/dts/overlays/hy28b-overlay.dts index 9edd0848d5550d..421bde94a4a0c3 100644 --- a/arch/arm/boot/dts/overlays/hy28b-overlay.dts +++ b/arch/arm/boot/dts/overlays/hy28b-overlay.dts @@ -128,7 +128,7 @@ spi-max-frequency = <2000000>; interrupts = <17 2>; /* high-to-low edge triggered */ interrupt-parent = <&gpio>; - pendown-gpio = <&gpio 17 0>; + pendown-gpio = <&gpio 17 1>; ti,x-plate-ohms = /bits/ 16 <100>; ti,pressure-max = /bits/ 16 <255>; }; diff --git a/arch/arm/boot/dts/overlays/mz61581-overlay.dts b/arch/arm/boot/dts/overlays/mz61581-overlay.dts index 6e00e8b2ddf2ac..101ad21d8093b7 100644 --- a/arch/arm/boot/dts/overlays/mz61581-overlay.dts +++ b/arch/arm/boot/dts/overlays/mz61581-overlay.dts @@ -99,7 +99,7 @@ spi-max-frequency = <2000000>; interrupts = <4 2>; /* high-to-low edge triggered */ interrupt-parent = <&gpio>; - pendown-gpio = <&gpio 4 0>; + pendown-gpio = <&gpio 4 1>; ti,x-plate-ohms = /bits/ 16 <60>; ti,pressure-max = /bits/ 16 <255>; diff --git a/arch/arm/boot/dts/overlays/piscreen-overlay.dts b/arch/arm/boot/dts/overlays/piscreen-overlay.dts index 8fa2426f71144c..29bcd41f39cfc9 100644 --- a/arch/arm/boot/dts/overlays/piscreen-overlay.dts +++ b/arch/arm/boot/dts/overlays/piscreen-overlay.dts @@ -87,7 +87,7 @@ spi-max-frequency = <2000000>; interrupts = <17 2>; /* high-to-low edge triggered */ interrupt-parent = <&gpio>; - pendown-gpio = <&gpio 17 0>; + pendown-gpio = <&gpio 17 GPIO_ACTIVE_LOW>; ti,swap-xy; ti,x-plate-ohms = /bits/ 16 <100>; ti,pressure-max = /bits/ 16 <255>; diff --git a/arch/arm/boot/dts/overlays/piscreen2r-overlay.dts b/arch/arm/boot/dts/overlays/piscreen2r-overlay.dts index 9d2b51101969e3..4468f4a54bf7a9 100644 --- a/arch/arm/boot/dts/overlays/piscreen2r-overlay.dts +++ b/arch/arm/boot/dts/overlays/piscreen2r-overlay.dts @@ -88,7 +88,7 @@ spi-max-frequency = <2000000>; interrupts = <17 2>; /* high-to-low edge triggered */ interrupt-parent = <&gpio>; - pendown-gpio = <&gpio 17 0>; + pendown-gpio = <&gpio 17 1>; ti,swap-xy; ti,x-plate-ohms = /bits/ 16 <100>; ti,pressure-max = /bits/ 16 <255>; diff --git a/arch/arm/boot/dts/overlays/tinylcd35-overlay.dts b/arch/arm/boot/dts/overlays/tinylcd35-overlay.dts index a102b09e3ab56f..edc5889b6f5f11 100644 --- a/arch/arm/boot/dts/overlays/tinylcd35-overlay.dts +++ b/arch/arm/boot/dts/overlays/tinylcd35-overlay.dts @@ -121,7 +121,7 @@ spi-max-frequency = <2000000>; interrupts = <5 2>; /* high-to-low edge triggered */ interrupt-parent = <&gpio>; - pendown-gpio = <&gpio 5 0>; + pendown-gpio = <&gpio 5 1>; ti,x-plate-ohms = /bits/ 16 <100>; ti,pressure-max = /bits/ 16 <255>; };