feat: TextArea component style only accepts the resize parameter by jin19980928 · Pull Request #296 · react-component/mentions

jin19980928 · 2025-06-10T07:25:02Z

Summary by CodeRabbit

新功能
- 现在支持通过样式属性自定义 Mentions 组件文本框的 resize 行为。
测试
- 增加了针对文本框 resize 样式的测试用例，确保样式设置正确。

coderabbitai · 2025-06-10T07:25:08Z

Warning

Rate limit exceeded

@jin19980928 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 43 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 084edf2 and ebc3c89.

📒 Files selected for processing (2)

src/Mentions.tsx (1 hunks)
tests/Mentions.spec.tsx (1 hunks)

Walkthrough

本次更改在 InternalMentions 组件中的 TextArea 元素上，显式设置了 resize 样式属性，使其根据传入的 style 属性中的 resize 值进行调整。同时，新增了两个测试用例，验证 resize 样式的正确应用与缺省情况。

Changes

文件/文件组	变更摘要
src/Mentions.tsx	在 `TextArea` 组件上添加 `style={{ resize: style?.resize }}`，根据传入的 `style` 属性设置 `resize` 样式。
tests/Mentions.spec.tsx	新增两个测试用例，分别验证 `resize` 样式被正确设置及未设置时的表现。

Poem

小兔挥笔改样式，
只为输入框能自如。
resize 属性随心设，
测试细致不马虎。
新代码，旧习惯，
代码世界添新舞！
🐇✨

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-06-10T07:29:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.04%. Comparing base (eac9183) to head (ebc3c89).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #296   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files           8        8           
  Lines         256      256           
  Branches       59       60    +1     
=======================================
  Hits          251      251           
  Misses          5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

zombieJ · 2025-06-10T07:42:20Z

      >
        <TextArea
          classNames={{ textarea: mentionClassNames?.textarea }}
+          style={{ resize: style?.resize }}


加个备注吧，说明一下是参考 TextArea 的

afc163 · 2025-06-10T08:36:35Z

+    it('should not apply resize style if not provided', () => {
+      const { container } = render(
+        <Mentions>
+          <Option value="bamboo">Bamboo</Option>
+          <Option value="light">Light</Option>
+          <Option value="cat">Cat</Option>
+        </Mentions>,
+      );
+
+      const textarea = container.querySelector('textarea');
+      expect(textarea).not.toBeNull();
+      expect(textarea?.style.resize).toBe('');
+    });


留上面那个用例就够了，下面这个意义不大。

feat:textareaStyle

eb05c83

zombieJ approved these changes Jun 10, 2025

View reviewed changes

zombieJ reviewed Jun 10, 2025

View reviewed changes

afc163 reviewed Jun 10, 2025

View reviewed changes

Comment thread src/Mentions.tsx

WB01676250 added 4 commits June 10, 2025 15:58

feat:textareaStyle

8c3c524

feat:textareaStyle

865e6e4

feat:textareaStyle

168503b

feat:textareaStyle

084edf2

afc163 reviewed Jun 10, 2025

View reviewed changes

WB01676250 added 2 commits June 10, 2025 16:40

feat:textareaStyle

f37fcae

feat:textareaStyle

a9cd046

afc163 changed the title ~~feat:TextArea component style only accepts the resize parameter~~ feat: TextArea component style only accepts the resize parameter Jun 10, 2025

WB01676250 added 2 commits June 10, 2025 16:43

feat:textareaStyle

de7ae8e

feat:textareaStyle

ebc3c89

zombieJ approved these changes Jun 10, 2025

View reviewed changes

zombieJ merged commit bb30810 into react-component:master Jun 10, 2025
7 checks passed

thinkasany mentioned this pull request Jun 10, 2025

fix: mentions sets the autosize property, and the icon in the bottom right corner supports manual height adjustment ant-design/ant-design#54039

Merged

1 task

coderabbitai Bot mentioned this pull request Nov 7, 2025

fix: resize style should work #305

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: TextArea component style only accepts the resize parameter#296

feat: TextArea component style only accepts the resize parameter#296
zombieJ merged 9 commits into
react-component:masterfrom
jin19980928:feat/textareaStyle

jin19980928 commented Jun 10, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 10, 2025 •

edited

Loading

Rate limit exceeded

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov Bot commented Jun 10, 2025 •

edited

Loading

Uh oh!

zombieJ Jun 10, 2025

Uh oh!

jin19980928 Jun 10, 2025

Uh oh!

Uh oh!

afc163 Jun 10, 2025

Uh oh!

jin19980928 Jun 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jin19980928 commented Jun 10, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov Bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zombieJ Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

jin19980928 Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

afc163 Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

jin19980928 Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jin19980928 commented Jun 10, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 10, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov Bot commented Jun 10, 2025 •

edited

Loading