From 80431dca6e06d5f3b1cc3e6e91f476698dba0fa2 Mon Sep 17 00:00:00 2001
From: aojunhao <1844749591@qq.com>
Date: Fri, 24 Jan 2025 17:35:55 +0800
Subject: [PATCH 1/2] fix: correct role for a11y

---
 src/Rate.tsx                            | 1 -
 src/Star.tsx                            | 2 +-
 tests/__snapshots__/simple.spec.js.snap | 7 -------
 3 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/src/Rate.tsx b/src/Rate.tsx
index b3285b9..46602ba 100644
--- a/src/Rate.tsx
+++ b/src/Rate.tsx
@@ -238,7 +238,6 @@ function Rate(props: RateProps, ref: React.Ref<RateRef>) {
       onBlur={disabled ? null : onInternalBlur}
       onKeyDown={disabled ? null : onInternalKeyDown}
       ref={rateRef}
-      role="radiogroup"
       {...pickAttrs(restProps, { aria: true, data: true, attr: true })}
     >
       {starNodes}
diff --git a/src/Star.tsx b/src/Star.tsx
index 7243069..7b54f4d 100644
--- a/src/Star.tsx
+++ b/src/Star.tsx
@@ -79,10 +79,10 @@ function Star(props: StarProps, ref: React.Ref<HTMLLIElement>) {
   let start: React.ReactNode = (
     <li className={classNames(Array.from(classNameList))} ref={ref}>
       <div
+        role="radio"
         onClick={disabled ? null : onInternalClick}
         onKeyDown={disabled ? null : onInternalKeyDown}
         onMouseMove={disabled ? null : onInternalHover}
-        role="radio"
         aria-checked={value > index ? 'true' : 'false'}
         aria-posinset={index + 1}
         aria-setsize={count}
diff --git a/tests/__snapshots__/simple.spec.js.snap b/tests/__snapshots__/simple.spec.js.snap
index 3fabfc8..43deb96 100644
--- a/tests/__snapshots__/simple.spec.js.snap
+++ b/tests/__snapshots__/simple.spec.js.snap
@@ -3,7 +3,6 @@
 exports[`rate allowHalf render works 1`] = `
 <ul
   class="rc-rate custom"
-  role="radiogroup"
   tabindex="0"
 >
   <li
@@ -78,7 +77,6 @@ exports[`rate allowHalf render works 1`] = `
 exports[`rate allowHalf render works in RTL 1`] = `
 <ul
   class="rc-rate custom rc-rate-rtl"
-  role="radiogroup"
   tabindex="0"
 >
   <li
@@ -153,7 +151,6 @@ exports[`rate allowHalf render works in RTL 1`] = `
 exports[`rate allowHalf render works more than half  1`] = `
 <ul
   class="rc-rate custom"
-  role="radiogroup"
   tabindex="0"
 >
   <li
@@ -228,7 +225,6 @@ exports[`rate allowHalf render works more than half  1`] = `
 exports[`rate full render works 1`] = `
 <ul
   class="rc-rate custom"
-  role="radiogroup"
   tabindex="0"
 >
   <li
@@ -303,7 +299,6 @@ exports[`rate full render works 1`] = `
 exports[`rate full render works in RTL 1`] = `
 <ul
   class="rc-rate custom rc-rate-rtl"
-  role="radiogroup"
   tabindex="0"
 >
   <li
@@ -378,7 +373,6 @@ exports[`rate full render works in RTL 1`] = `
 exports[`rate full render works with character function 1`] = `
 <ul
   class="rc-rate"
-  role="radiogroup"
   tabindex="0"
 >
   <li
@@ -453,7 +447,6 @@ exports[`rate full render works with character function 1`] = `
 exports[`rate full render works with character node 1`] = `
 <ul
   class="rc-rate"
-  role="radiogroup"
   tabindex="0"
 >
   <li

From e95075212752bf9dd79c4baa3c4593a1b8824f5e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B0=8F=E8=B1=AA?= <1844749591@qq.com>
Date: Fri, 24 Jan 2025 17:39:19 +0800
Subject: [PATCH 2/2] chore: not blame

---
 src/Star.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Star.tsx b/src/Star.tsx
index 7b54f4d..7243069 100644
--- a/src/Star.tsx
+++ b/src/Star.tsx
@@ -79,10 +79,10 @@ function Star(props: StarProps, ref: React.Ref<HTMLLIElement>) {
   let start: React.ReactNode = (
     <li className={classNames(Array.from(classNameList))} ref={ref}>
       <div
-        role="radio"
         onClick={disabled ? null : onInternalClick}
         onKeyDown={disabled ? null : onInternalKeyDown}
         onMouseMove={disabled ? null : onInternalHover}
+        role="radio"
         aria-checked={value > index ? 'true' : 'false'}
         aria-posinset={index + 1}
         aria-setsize={count}