From f1d99819e55cf13f99b522a15197177155ad3cdb Mon Sep 17 00:00:00 2001 From: afc163 Date: Mon, 29 Jun 2026 18:20:12 +0800 Subject: [PATCH 1/7] chore: update maintenance dependencies --- .github/dependabot.yml | 8 +++++ README.md | 2 +- README.zh-CN.md | 2 +- eslint.config.mjs | 79 +++++++++++++++++++++++++++++++++++++++++ examples/no-virtual.tsx | 4 +-- examples/switch.tsx | 4 +-- global.d.ts | 56 +++++++++++++++++++++++++++++ package.json | 30 ++++++++++------ react-compat.d.ts | 16 +++++++++ src/Item.tsx | 2 +- tsconfig.json | 11 +++++- 11 files changed, 196 insertions(+), 18 deletions(-) create mode 100644 eslint.config.mjs create mode 100644 global.d.ts create mode 100644 react-compat.d.ts diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 3b730ef9..5e6c7faa 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -8,6 +8,10 @@ updates: time: '21:00' timezone: Asia/Shanghai open-pull-requests-limit: 10 + groups: + npm-dependencies: + patterns: + - '*' - package-ecosystem: github-actions directory: '/' @@ -17,3 +21,7 @@ updates: time: '21:00' timezone: Asia/Shanghai open-pull-requests-limit: 10 + groups: + github-actions: + patterns: + - '*' diff --git a/README.md b/README.md index 0d63d5f0..33f2d992 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@

@rc-component/virtual-list

-

Ant Design Part of the Ant Design ecosystem.

+

Ant Design Part of the Ant Design ecosystem.

πŸ“œ Virtual scrolling list component for React.

diff --git a/README.zh-CN.md b/README.zh-CN.md index d0a3192e..d1cbe56b 100644 --- a/README.zh-CN.md +++ b/README.zh-CN.md @@ -1,6 +1,6 @@

@rc-component/virtual-list

-

Ant Design Ant Design η”Ÿζ€ηš„δΈ€ιƒ¨εˆ†γ€‚

+

Ant Design Ant Design η”Ÿζ€ηš„δΈ€ιƒ¨εˆ†γ€‚

πŸ“œ React θ™šζ‹Ÿεˆ—θ‘¨η»„δ»ΆοΌŒη”¨δΊŽι«˜ζ€§θƒ½ζΈ²ζŸ“ι•Ώεˆ—θ‘¨γ€‚

diff --git a/eslint.config.mjs b/eslint.config.mjs new file mode 100644 index 00000000..b25fb5dd --- /dev/null +++ b/eslint.config.mjs @@ -0,0 +1,79 @@ +import { FlatCompat } from '@eslint/eslintrc'; +import js from '@eslint/js'; +import tsEslintPlugin from '@typescript-eslint/eslint-plugin'; +import { createRequire } from 'node:module'; +import path from 'node:path'; +import { fileURLToPath } from 'node:url'; + +const __filename = fileURLToPath(import.meta.url); +const __dirname = path.dirname(__filename); +const require = createRequire(import.meta.url); + +const compat = new FlatCompat({ + baseDirectory: __dirname, + recommendedConfig: js.configs.recommended, + allConfig: js.configs.all, +}); + +const recommendedTsRules = new Set(Object.keys(tsEslintPlugin.configs.recommended.rules || {})); +const noopRule = { + meta: { type: 'problem', docs: {}, schema: [] }, + create: () => ({}), +}; + +function normalizeConfig(config) { + const next = { ...config }; + + if (next.plugins?.['@typescript-eslint']) { + next.plugins = { + ...next.plugins, + '@typescript-eslint': { + ...next.plugins['@typescript-eslint'], + rules: { + ...next.plugins['@typescript-eslint'].rules, + 'ban-types': noopRule, + }, + }, + }; + } + + if (next.rules) { + next.rules = Object.fromEntries( + Object.entries(next.rules).filter(([ruleName]) => { + if (!ruleName.startsWith('@typescript-eslint/')) { + return true; + } + return recommendedTsRules.has(ruleName) || ruleName === '@typescript-eslint/ban-types'; + }), + ); + } + + return next; +} + +export default [ + { + ignores: [ + 'node_modules/', + 'coverage/', + 'es/', + 'lib/', + 'dist/', + 'docs-dist/', + '.dumi/', + '.doc/', + '.vercel/', + '.eslintrc.js', + 'src/index.d.ts', + ], + }, + ...compat.config(require('./.eslintrc.js')).map(normalizeConfig), + { + rules: { + '@typescript-eslint/ban-types': 'off', + '@typescript-eslint/no-empty-object-type': 'off', + '@typescript-eslint/no-unsafe-function-type': 'off', + '@typescript-eslint/no-unused-vars': 'off', + }, + }, +]; diff --git a/examples/no-virtual.tsx b/examples/no-virtual.tsx index 793ab907..d48e0dfe 100644 --- a/examples/no-virtual.tsx +++ b/examples/no-virtual.tsx @@ -7,7 +7,7 @@ interface Item { height: number; } -const MyItem: React.FC = ({ id, height }, ref) => { +const MyItem = React.forwardRef(({ id, height }, ref) => { return ( = ({ id, height }, ref) => { {id} ); -}; +}); const ForwardMyItem = React.forwardRef(MyItem as any); diff --git a/examples/switch.tsx b/examples/switch.tsx index 5339e887..5d56dcb4 100644 --- a/examples/switch.tsx +++ b/examples/switch.tsx @@ -6,7 +6,7 @@ interface Item { id: number; } -const MyItem: React.FC = ({ id }, ref) => ( +const MyItem = React.forwardRef(({ id }, ref) => ( = ({ id }, ref) => ( > {id} -); +)); const ForwardMyItem = React.forwardRef(MyItem as any); diff --git a/global.d.ts b/global.d.ts new file mode 100644 index 00000000..e35e1773 --- /dev/null +++ b/global.d.ts @@ -0,0 +1,56 @@ +/// +/// +/// +/// +/// + +declare module '*.css'; +declare module '*.less'; +declare module 'jsonp'; + +declare namespace JSX { + type Element = React.JSX.Element; + interface ElementClass extends React.JSX.ElementClass {} + interface ElementAttributesProperty extends React.JSX.ElementAttributesProperty {} + interface ElementChildrenAttribute extends React.JSX.ElementChildrenAttribute {} + type LibraryManagedAttributes = React.JSX.LibraryManagedAttributes; + interface IntrinsicAttributes extends React.JSX.IntrinsicAttributes {} + interface IntrinsicClassAttributes extends React.JSX.IntrinsicClassAttributes {} + interface IntrinsicElements extends React.JSX.IntrinsicElements {} +} + +declare namespace jest { + interface Matchers { + lastCalledWith(...expected: unknown[]): R; + nthCalledWith(nthCall: number, ...expected: unknown[]): R; + toBeCalled(): R; + toBeCalledTimes(expected: number): R; + toBeCalledWith(...expected: unknown[]): R; + } +} + +declare const vi: { + fn: any = (...args: any[]) => any>(implementation?: T) => jest.MockedFunction; + mock: (moduleName: string, factory?: (importOriginal: () => Promise) => unknown) => void; + spyOn: typeof jest.spyOn; + useFakeTimers: () => void; + useRealTimers: () => void; + advanceTimersByTime: (msToRun: number) => void; + clearAllTimers: () => void; + runAllTimers: () => void; + importActual: (moduleName: string) => Promise; + clearAllMocks: () => void; + resetAllMocks: () => void; + restoreAllMocks: () => void; +}; + +declare const describe: any; +declare const it: any; +declare const test: any; +declare const beforeEach: any; +declare const afterEach: any; +declare const beforeAll: any; +declare const afterAll: any; +declare const expect: any; + +declare module 'moment/locale/zh-cn'; diff --git a/package.json b/package.json index 62e4e0d9..97d861dc 100644 --- a/package.json +++ b/package.json @@ -51,27 +51,37 @@ "@rc-component/father-plugin": "^2.2.0", "@rc-component/np": "^1.0.4", "@testing-library/jest-dom": "^6.9.1", - "@testing-library/react": "^15.0.7", - "@types/jest": "^29.5.14", + "@testing-library/react": "^16.3.2", + "@types/jest": "^30.0.0", "@types/node": "^26.0.1", - "@types/react": "^18.3.31", - "@types/react-dom": "^18.3.7", + "@types/react": "^19.2.17", + "@types/react-dom": "^19.2.3", "@types/warning": "^3.0.4", "dumi": "^2.4.35", - "eslint": "^8.57.1", - "eslint-plugin-unicorn": "^56.0.1", + "eslint": "^9.39.4", + "eslint-plugin-unicorn": "^65.0.1", "father": "^4.6.23", "glob": "^13.0.6", "rc-animate": "^2.9.1", "rc-test": "^7.1.3", - "react": "^18.3.1", - "react-dom": "^18.3.1", - "typescript": "^5.9.3", + "react": "^19.2.7", + "react-dom": "^19.2.7", + "typescript": "^6.0.3", "cross-env": "^10.1.0", "gh-pages": "^6.3.0", "prettier": "^3.9.0", "husky": "^9.1.7", - "lint-staged": "^16.4.0" + "lint-staged": "^17.0.8", + "@eslint/eslintrc": "^3.3.5", + "@eslint/js": "^9.39.4", + "eslint-plugin-react": "^7.37.5", + "eslint-plugin-react-hooks": "^7.1.1", + "eslint-config-prettier": "^10.1.8", + "@babel/eslint-parser": "^7.29.7", + "@babel/eslint-plugin": "^7.29.7", + "@typescript-eslint/eslint-plugin": "^8.62.0", + "@typescript-eslint/parser": "^8.62.0", + "eslint-plugin-jest": "^29.15.3" }, "dependencies": { "@babel/runtime": "^7.20.0", diff --git a/react-compat.d.ts b/react-compat.d.ts new file mode 100644 index 00000000..ff05aa1b --- /dev/null +++ b/react-compat.d.ts @@ -0,0 +1,16 @@ +import * as React from 'react'; + +declare module 'react' { + type ReactText = string | number; + function useRef(): React.MutableRefObject; + function isValidElement

(object: {} | null | undefined): object is React.ReactElement

; + function cloneElement

( + element: React.ReactElement

, + props?: (Partial

& React.Attributes) | null, + ...children: React.ReactNode[] + ): React.ReactElement

; +} + +declare module 'react-dom' { + function hydrate(element: React.ReactNode, container: Element | DocumentFragment): void; +} diff --git a/src/Item.tsx b/src/Item.tsx index 8a8cb6c5..bfc8dce9 100644 --- a/src/Item.tsx +++ b/src/Item.tsx @@ -10,7 +10,7 @@ export function Item({ children, setRef }: ItemProps) { setRef(node); }, []); - return React.cloneElement(children, { + return React.cloneElement(children as React.ReactElement, { ref: refFunc, }); } diff --git a/tsconfig.json b/tsconfig.json index edc503cd..6f2cfaa7 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -24,9 +24,18 @@ "src/*" ] }, - "ignoreDeprecations": "5.0" + "ignoreDeprecations": "6.0", + "noImplicitAny": false, + "strictNullChecks": false, + "strictPropertyInitialization": false, + "strictFunctionTypes": false, + "strict": false, + "noImplicitThis": false, + "strictBindCallApply": false }, "include": [ + "react-compat.d.ts", + "global.d.ts", ".dumirc.ts", ".fatherrc.ts", "src", From 18e3af813ba88e4988f197d9aa383f06c43553ac Mon Sep 17 00:00:00 2001 From: afc163 Date: Tue, 30 Jun 2026 10:21:39 +0800 Subject: [PATCH 2/7] fix: align TypeScript and ESLint compatibility --- eslint.config.mjs | 33 +++++++++++++++++++++------------ global.d.ts | 8 -------- tsconfig.json | 17 ++++++++--------- 3 files changed, 29 insertions(+), 29 deletions(-) diff --git a/eslint.config.mjs b/eslint.config.mjs index b25fb5dd..f556e5a4 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -15,7 +15,9 @@ const compat = new FlatCompat({ allConfig: js.configs.all, }); -const recommendedTsRules = new Set(Object.keys(tsEslintPlugin.configs.recommended.rules || {})); +const recommendedTsRules = new Set( + Object.keys(tsEslintPlugin.configs.recommended.rules || {}), +); const noopRule = { meta: { type: 'problem', docs: {}, schema: [] }, create: () => ({}), @@ -25,16 +27,8 @@ function normalizeConfig(config) { const next = { ...config }; if (next.plugins?.['@typescript-eslint']) { - next.plugins = { - ...next.plugins, - '@typescript-eslint': { - ...next.plugins['@typescript-eslint'], - rules: { - ...next.plugins['@typescript-eslint'].rules, - 'ban-types': noopRule, - }, - }, - }; + next.plugins = { ...next.plugins }; + delete next.plugins['@typescript-eslint']; } if (next.rules) { @@ -43,7 +37,10 @@ function normalizeConfig(config) { if (!ruleName.startsWith('@typescript-eslint/')) { return true; } - return recommendedTsRules.has(ruleName) || ruleName === '@typescript-eslint/ban-types'; + return ( + recommendedTsRules.has(ruleName) || + ruleName === '@typescript-eslint/ban-types' + ); }), ); } @@ -67,6 +64,18 @@ export default [ 'src/index.d.ts', ], }, + { + plugins: { + '@typescript-eslint': { + ...tsEslintPlugin, + rules: { + ...tsEslintPlugin.rules, + 'ban-types': noopRule, + 'consistent-type-exports': noopRule, + }, + }, + }, + }, ...compat.config(require('./.eslintrc.js')).map(normalizeConfig), { rules: { diff --git a/global.d.ts b/global.d.ts index e35e1773..97e90a38 100644 --- a/global.d.ts +++ b/global.d.ts @@ -44,13 +44,5 @@ declare const vi: { restoreAllMocks: () => void; }; -declare const describe: any; -declare const it: any; -declare const test: any; -declare const beforeEach: any; -declare const afterEach: any; -declare const beforeAll: any; -declare const afterAll: any; -declare const expect: any; declare module 'moment/locale/zh-cn'; diff --git a/tsconfig.json b/tsconfig.json index 6f2cfaa7..267591e1 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -1,37 +1,36 @@ { "compilerOptions": { "target": "esnext", - "moduleResolution": "node", - "baseUrl": "./", + "moduleResolution": "bundler", "jsx": "react", "declaration": true, "skipLibCheck": true, "esModuleInterop": true, "paths": { "@/*": [ - "src/*" + "./src/*" ], "@@/*": [ - ".dumi/tmp/*" + "./.dumi/tmp/*" ], "@rc-component/virtual-list": [ - "src/index.ts" + "./src/index.ts" ], "@rc-component/virtual-list/es": [ - "src" + "./src" ], "@rc-component/virtual-list/es/*": [ - "src/*" + "./src/*" ] }, - "ignoreDeprecations": "6.0", "noImplicitAny": false, "strictNullChecks": false, "strictPropertyInitialization": false, "strictFunctionTypes": false, "strict": false, "noImplicitThis": false, - "strictBindCallApply": false + "strictBindCallApply": false, + "module": "ESNext" }, "include": [ "react-compat.d.ts", From 587c2d472b066dd4de3719eea67af708437600a2 Mon Sep 17 00:00:00 2001 From: afc163 Date: Tue, 30 Jun 2026 10:51:49 +0800 Subject: [PATCH 3/7] chore: use testing-library dom events --- package.json | 33 +++++++++++++++++---------------- tests/list.test.js | 3 ++- tests/scroll.test.js | 3 ++- tests/scrollWidth.test.tsx | 3 ++- tests/touch.test.js | 3 ++- 5 files changed, 25 insertions(+), 20 deletions(-) diff --git a/package.json b/package.json index 97d861dc..7c7a24b2 100644 --- a/package.json +++ b/package.json @@ -48,8 +48,13 @@ "react-dom": ">=18.0.0" }, "devDependencies": { + "@babel/eslint-parser": "^7.29.7", + "@babel/eslint-plugin": "^7.29.7", + "@eslint/eslintrc": "^3.3.5", + "@eslint/js": "^9.39.4", "@rc-component/father-plugin": "^2.2.0", "@rc-component/np": "^1.0.4", + "@testing-library/dom": "^10.4.1", "@testing-library/jest-dom": "^6.9.1", "@testing-library/react": "^16.3.2", "@types/jest": "^30.0.0", @@ -57,31 +62,27 @@ "@types/react": "^19.2.17", "@types/react-dom": "^19.2.3", "@types/warning": "^3.0.4", + "@typescript-eslint/eslint-plugin": "^8.62.0", + "@typescript-eslint/parser": "^8.62.0", + "cross-env": "^10.1.0", "dumi": "^2.4.35", "eslint": "^9.39.4", + "eslint-config-prettier": "^10.1.8", + "eslint-plugin-jest": "^29.15.3", + "eslint-plugin-react": "^7.37.5", + "eslint-plugin-react-hooks": "^7.1.1", "eslint-plugin-unicorn": "^65.0.1", "father": "^4.6.23", + "gh-pages": "^6.3.0", "glob": "^13.0.6", + "husky": "^9.1.7", + "lint-staged": "^17.0.8", + "prettier": "^3.9.0", "rc-animate": "^2.9.1", "rc-test": "^7.1.3", "react": "^19.2.7", "react-dom": "^19.2.7", - "typescript": "^6.0.3", - "cross-env": "^10.1.0", - "gh-pages": "^6.3.0", - "prettier": "^3.9.0", - "husky": "^9.1.7", - "lint-staged": "^17.0.8", - "@eslint/eslintrc": "^3.3.5", - "@eslint/js": "^9.39.4", - "eslint-plugin-react": "^7.37.5", - "eslint-plugin-react-hooks": "^7.1.1", - "eslint-config-prettier": "^10.1.8", - "@babel/eslint-parser": "^7.29.7", - "@babel/eslint-plugin": "^7.29.7", - "@typescript-eslint/eslint-plugin": "^8.62.0", - "@typescript-eslint/parser": "^8.62.0", - "eslint-plugin-jest": "^29.15.3" + "typescript": "^6.0.3" }, "dependencies": { "@babel/runtime": "^7.20.0", diff --git a/tests/list.test.js b/tests/list.test.js index d0317b61..0922a97c 100644 --- a/tests/list.test.js +++ b/tests/list.test.js @@ -1,6 +1,7 @@ import '@testing-library/jest-dom'; +import { fireEvent } from '@testing-library/dom'; import { _rs as onLibResize } from '@rc-component/resize-observer/lib/utils/observerUtil'; -import { act, fireEvent, render } from '@testing-library/react'; +import { act, render } from '@testing-library/react'; import React from 'react'; import List from '../src'; import { spyElementPrototypes } from './utils/domHook'; diff --git a/tests/scroll.test.js b/tests/scroll.test.js index a7bb1700..890d857b 100644 --- a/tests/scroll.test.js +++ b/tests/scroll.test.js @@ -1,5 +1,6 @@ import '@testing-library/jest-dom'; -import { act, createEvent, fireEvent, render } from '@testing-library/react'; +import { createEvent, fireEvent } from '@testing-library/dom'; +import { act, render } from '@testing-library/react'; import { _rs as onLibResize } from '@rc-component/resize-observer/lib/utils/observerUtil'; import { resetWarned } from '@rc-component/util/lib/warning'; import React from 'react'; diff --git a/tests/scrollWidth.test.tsx b/tests/scrollWidth.test.tsx index 22326322..367e9f26 100644 --- a/tests/scrollWidth.test.tsx +++ b/tests/scrollWidth.test.tsx @@ -1,5 +1,6 @@ import '@testing-library/jest-dom'; -import { act, fireEvent, render } from '@testing-library/react'; +import { fireEvent } from '@testing-library/dom'; +import { act, render } from '@testing-library/react'; import { _rs as onLibResize } from '@rc-component/resize-observer/lib/utils/observerUtil'; import { spyElementPrototypes } from '@rc-component/util/lib/test/domHook'; import React from 'react'; diff --git a/tests/touch.test.js b/tests/touch.test.js index d0a5072f..cecfb506 100644 --- a/tests/touch.test.js +++ b/tests/touch.test.js @@ -1,4 +1,5 @@ -import { act, fireEvent, render } from '@testing-library/react'; +import { fireEvent } from '@testing-library/dom'; +import { act, render } from '@testing-library/react'; import React from 'react'; import List from '../src'; import { spyElementPrototypes } from './utils/domHook'; From b99f2634fb6407a6b9344d30f9ab3d6f054c4b94 Mon Sep 17 00:00:00 2001 From: afc163 Date: Tue, 30 Jun 2026 11:16:58 +0800 Subject: [PATCH 4/7] test: keep react testing event behavior --- tests/list.test.js | 3 +-- tests/scroll.test.js | 3 +-- tests/scrollWidth.test.tsx | 3 +-- tests/touch.test.js | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/tests/list.test.js b/tests/list.test.js index 0922a97c..d0317b61 100644 --- a/tests/list.test.js +++ b/tests/list.test.js @@ -1,7 +1,6 @@ import '@testing-library/jest-dom'; -import { fireEvent } from '@testing-library/dom'; import { _rs as onLibResize } from '@rc-component/resize-observer/lib/utils/observerUtil'; -import { act, render } from '@testing-library/react'; +import { act, fireEvent, render } from '@testing-library/react'; import React from 'react'; import List from '../src'; import { spyElementPrototypes } from './utils/domHook'; diff --git a/tests/scroll.test.js b/tests/scroll.test.js index 890d857b..a7bb1700 100644 --- a/tests/scroll.test.js +++ b/tests/scroll.test.js @@ -1,6 +1,5 @@ import '@testing-library/jest-dom'; -import { createEvent, fireEvent } from '@testing-library/dom'; -import { act, render } from '@testing-library/react'; +import { act, createEvent, fireEvent, render } from '@testing-library/react'; import { _rs as onLibResize } from '@rc-component/resize-observer/lib/utils/observerUtil'; import { resetWarned } from '@rc-component/util/lib/warning'; import React from 'react'; diff --git a/tests/scrollWidth.test.tsx b/tests/scrollWidth.test.tsx index 367e9f26..22326322 100644 --- a/tests/scrollWidth.test.tsx +++ b/tests/scrollWidth.test.tsx @@ -1,6 +1,5 @@ import '@testing-library/jest-dom'; -import { fireEvent } from '@testing-library/dom'; -import { act, render } from '@testing-library/react'; +import { act, fireEvent, render } from '@testing-library/react'; import { _rs as onLibResize } from '@rc-component/resize-observer/lib/utils/observerUtil'; import { spyElementPrototypes } from '@rc-component/util/lib/test/domHook'; import React from 'react'; diff --git a/tests/touch.test.js b/tests/touch.test.js index cecfb506..d0a5072f 100644 --- a/tests/touch.test.js +++ b/tests/touch.test.js @@ -1,5 +1,4 @@ -import { fireEvent } from '@testing-library/dom'; -import { act, render } from '@testing-library/react'; +import { act, fireEvent, render } from '@testing-library/react'; import React from 'react'; import List from '../src'; import { spyElementPrototypes } from './utils/domHook'; From 9a53eeef94d496a050aaea6421a9de9dacadc7cf Mon Sep 17 00:00:00 2001 From: afc163 Date: Tue, 30 Jun 2026 19:04:52 +0800 Subject: [PATCH 5/7] chore: address review comments --- eslint.config.mjs | 30 ++++++++++-------------------- react-compat.d.ts | 4 ---- 2 files changed, 10 insertions(+), 24 deletions(-) diff --git a/eslint.config.mjs b/eslint.config.mjs index f556e5a4..3166a6d9 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -15,13 +15,14 @@ const compat = new FlatCompat({ allConfig: js.configs.all, }); -const recommendedTsRules = new Set( - Object.keys(tsEslintPlugin.configs.recommended.rules || {}), -); -const noopRule = { - meta: { type: 'problem', docs: {}, schema: [] }, - create: () => ({}), -}; +const recommendedTsRulesConfig = tsEslintPlugin.configs.recommended; +const recommendedTsRulesObject = Array.isArray(recommendedTsRulesConfig) + ? recommendedTsRulesConfig.reduce( + (rules, config) => ({ ...rules, ...(config.rules || {}) }), + {}, + ) + : recommendedTsRulesConfig?.rules || {}; +const recommendedTsRules = new Set(Object.keys(recommendedTsRulesObject)); function normalizeConfig(config) { const next = { ...config }; @@ -37,10 +38,7 @@ function normalizeConfig(config) { if (!ruleName.startsWith('@typescript-eslint/')) { return true; } - return ( - recommendedTsRules.has(ruleName) || - ruleName === '@typescript-eslint/ban-types' - ); + return recommendedTsRules.has(ruleName); }), ); } @@ -66,20 +64,12 @@ export default [ }, { plugins: { - '@typescript-eslint': { - ...tsEslintPlugin, - rules: { - ...tsEslintPlugin.rules, - 'ban-types': noopRule, - 'consistent-type-exports': noopRule, - }, - }, + '@typescript-eslint': tsEslintPlugin, }, }, ...compat.config(require('./.eslintrc.js')).map(normalizeConfig), { rules: { - '@typescript-eslint/ban-types': 'off', '@typescript-eslint/no-empty-object-type': 'off', '@typescript-eslint/no-unsafe-function-type': 'off', '@typescript-eslint/no-unused-vars': 'off', diff --git a/react-compat.d.ts b/react-compat.d.ts index ff05aa1b..c509fe40 100644 --- a/react-compat.d.ts +++ b/react-compat.d.ts @@ -10,7 +10,3 @@ declare module 'react' { ...children: React.ReactNode[] ): React.ReactElement

; } - -declare module 'react-dom' { - function hydrate(element: React.ReactNode, container: Element | DocumentFragment): void; -} From c392e698dd4056b48f1c4410bef736195f2acb4e Mon Sep 17 00:00:00 2001 From: afc163 Date: Tue, 30 Jun 2026 19:17:29 +0800 Subject: [PATCH 6/7] fix: keep compatible eslint export rule --- eslint.config.mjs | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/eslint.config.mjs b/eslint.config.mjs index 3166a6d9..0e70eed9 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -23,6 +23,10 @@ const recommendedTsRulesObject = Array.isArray(recommendedTsRulesConfig) ) : recommendedTsRulesConfig?.rules || {}; const recommendedTsRules = new Set(Object.keys(recommendedTsRulesObject)); +const noopRule = { + meta: { type: 'problem', docs: {}, schema: [] }, + create: () => ({}), +}; function normalizeConfig(config) { const next = { ...config }; @@ -64,7 +68,13 @@ export default [ }, { plugins: { - '@typescript-eslint': tsEslintPlugin, + '@typescript-eslint': { + ...tsEslintPlugin, + rules: { + ...tsEslintPlugin.rules, + 'consistent-type-exports': noopRule, + }, + }, }, }, ...compat.config(require('./.eslintrc.js')).map(normalizeConfig), From d2d4ff5c74ad417b83ccc8213e3e7baaf685baa7 Mon Sep 17 00:00:00 2001 From: afc163 Date: Tue, 30 Jun 2026 19:32:32 +0800 Subject: [PATCH 7/7] chore: address review suggestion --- src/Item.tsx | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Item.tsx b/src/Item.tsx index bfc8dce9..2839a539 100644 --- a/src/Item.tsx +++ b/src/Item.tsx @@ -6,9 +6,12 @@ export interface ItemProps { } export function Item({ children, setRef }: ItemProps) { - const refFunc = React.useCallback(node => { - setRef(node); - }, []); + const refFunc = React.useCallback( + node => { + setRef(node); + }, + [setRef], + ); return React.cloneElement(children as React.ReactElement, { ref: refFunc,