TestID's for e2e automation#2253
Merged
christopherdro merged 3 commits intoreact-native-maps:masterfrom Apr 14, 2019
Merged
Conversation
It seems that the following pull react-native-maps#1170 request has been abandoned, but testID is still required if one wants to make e2e tests react-native-maps#2252
|
Any chance to review and merge this? Would be great to allow Detox, for example, to find markers. |
|
Hey, just a quick update for anyone wondering about this. 'react-native-maps' currently supports the testID prop for markers for google maps on iOS (v0.23.0). However markers are not interactable, meaning you cannot tap on them. There are two workarounds I am currently implementing:
I am using the first approach because in my e2e tests I am able to create all my markers and then I can test with the newly created ones. |
christopherdro
changed the title
Contributor
|
Currently with UITests (XCTest) I can't even test for the marker's existence via its id. I don't think its working. |
Merged
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
* re-applying pull request 1170 It seems that the following pull react-native-maps#1170 request has been abandoned, but testID is still required if one wants to make e2e tests react-native-maps#2252 * Update App.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the following pull #1170 request has been abandoned, but testID is still required if one wants to make e2e tests
Does any other open PR do the same thing?
#1170
masterbranch and the author didn't fix themWhat issue is this PR fixing?
rendered markers don't have testID prop which is necessary for e2e tests
Closes #2252
Closes #1104
How did you test this PR?
Select the marker and it should have an identifier set in the Accessibility section on the right.
This was tested on a real device and simulator. The change applies to ios only.