Skip to content

Fix warning in RN >= 0.58 #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rborn merged 1 commit into from
Feb 4, 2019
Merged

Fix warning in RN >= 0.58 #2671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions lib/components/decorateMapComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,17 @@ export const createNotSupportedComponent = message => () => {
return null;
};

export const googleMapIsInstalled = !!NativeModules.UIManager[getAirMapName(PROVIDER_GOOGLE)];
function getViewManagerConfig(viewManagerName) {
const UIManager = NativeModules.UIManager;
if (!UIManager.getViewManagerConfig) {
Comment thread
rborn marked this conversation as resolved.
// RN < 0.58
return UIManager[viewManagerName];
}
// RN >= 0.58
return UIManager.getViewManagerConfig(viewManagerName);
}

export const googleMapIsInstalled = !!getViewManagerConfig(getAirMapName(PROVIDER_GOOGLE));

export default function decorateMapComponent(Component, { componentType, providers }) {
const components = {};
Expand Down Expand Up @@ -70,8 +80,8 @@ export default function decorateMapComponent(Component, { componentType, provide
};

Component.prototype.getUIManagerCommand = function getUIManagerCommand(name) { // eslint-disable-line no-param-reassign,max-len
return NativeModules.UIManager[getAirComponentName(this.context.provider, componentType)]
.Commands[name];
const componentName = getAirComponentName(this.context.provider, componentType);
return getViewManagerConfig(componentName).Commands[name];
};

Component.prototype.getMapManagerCommand = function getMapManagerCommand(name) { // eslint-disable-line no-param-reassign,max-len
Expand Down