Enable RN projects to define the Android AppCompat Library version (and fix dependency issues with RN 0.59 RC)#2702
Merged
alvelig merged 1 commit intoreact-native-maps:masterfrom Feb 20, 2019
Conversation
Collaborator
|
LGTM |
Contributor
|
LGTM |
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
…ompile-issues Enable RN projects to define the Android AppCompat Library version (and fix dependency issues with RN 0.59 RC)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
Issue #2695, a problem with the upcoming version of react-native. This should also work with all previous versions of RN.
How did you test this PR?
Test this PR before it got merged
You can test it with your project by installing this branch directly from GitHub:
npm install --save "react-native-maps@jerolimov/react-native-maps#fix-rn59rc-compile-issues"or
yarn add "react-native-maps@jerolimov/react-native-maps#fix-rn59rc-compile-issues"Remember to switch back to the official releases as soon as possible. 😏