From caf745b8604c79d8c1db73cd09843204cfff23ab Mon Sep 17 00:00:00 2001 From: Mrman Date: Fri, 15 May 2020 19:37:01 +0100 Subject: [PATCH 1/3] Pin to core-js 3.5.0 and add a peer dependency --- packages/babel-preset-react-app/create.js | 2 +- packages/babel-preset-react-app/dependencies.js | 3 +-- packages/babel-preset-react-app/package.json | 3 +++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/babel-preset-react-app/create.js b/packages/babel-preset-react-app/create.js index 473d0969f4e..e3b31bbed30 100644 --- a/packages/babel-preset-react-app/create.js +++ b/packages/babel-preset-react-app/create.js @@ -82,7 +82,7 @@ module.exports = function (api, opts, env) { // Allow importing core-js in entrypoint and use browserlist to select polyfills useBuiltIns: 'entry', // Set the corejs version we are using to avoid warnings in console - corejs: 3, + corejs: 3.5, // Do not transform modules to CJS modules: false, // Exclude transforms that make all code slower diff --git a/packages/babel-preset-react-app/dependencies.js b/packages/babel-preset-react-app/dependencies.js index 8c3256f15e8..1b0528c6712 100644 --- a/packages/babel-preset-react-app/dependencies.js +++ b/packages/babel-preset-react-app/dependencies.js @@ -87,8 +87,7 @@ module.exports = function (api, opts) { // Allow importing core-js in entrypoint and use browserlist to select polyfills useBuiltIns: 'entry', // Set the corejs version we are using to avoid warnings in console - // This will need to change once we upgrade to corejs@3 - corejs: 3, + corejs: 3.5, // Do not transform modules to CJS modules: false, // Exclude transforms that make all code slower diff --git a/packages/babel-preset-react-app/package.json b/packages/babel-preset-react-app/package.json index ef5d869ffa4..b943fb2d342 100644 --- a/packages/babel-preset-react-app/package.json +++ b/packages/babel-preset-react-app/package.json @@ -36,5 +36,8 @@ "@babel/runtime": "7.9.6", "babel-plugin-macros": "2.8.0", "babel-plugin-transform-react-remove-prop-types": "0.4.24" + }, + "peerDependencies": { + "core-js": "^3.5.0" } } From c7dbf276ca41cda642b739804ddb760e3c99fac9 Mon Sep 17 00:00:00 2001 From: Craig S Date: Fri, 22 May 2020 16:15:48 +0100 Subject: [PATCH 2/3] Update to '3.5' instead of number Co-authored-by: Minh Nguyen --- packages/babel-preset-react-app/dependencies.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/babel-preset-react-app/dependencies.js b/packages/babel-preset-react-app/dependencies.js index 1b0528c6712..7555233c7a9 100644 --- a/packages/babel-preset-react-app/dependencies.js +++ b/packages/babel-preset-react-app/dependencies.js @@ -87,7 +87,7 @@ module.exports = function (api, opts) { // Allow importing core-js in entrypoint and use browserlist to select polyfills useBuiltIns: 'entry', // Set the corejs version we are using to avoid warnings in console - corejs: 3.5, + corejs: '3.5', // Do not transform modules to CJS modules: false, // Exclude transforms that make all code slower From 291e10728b037c77f821b6c1ba73ba20f08f7e51 Mon Sep 17 00:00:00 2001 From: Craig S Date: Fri, 22 May 2020 16:16:04 +0100 Subject: [PATCH 3/3] Update to '3.5' instead of number Co-authored-by: Minh Nguyen --- packages/babel-preset-react-app/create.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/babel-preset-react-app/create.js b/packages/babel-preset-react-app/create.js index e3b31bbed30..fc16ba7604f 100644 --- a/packages/babel-preset-react-app/create.js +++ b/packages/babel-preset-react-app/create.js @@ -82,7 +82,7 @@ module.exports = function (api, opts, env) { // Allow importing core-js in entrypoint and use browserlist to select polyfills useBuiltIns: 'entry', // Set the corejs version we are using to avoid warnings in console - corejs: 3.5, + corejs: '3.5', // Do not transform modules to CJS modules: false, // Exclude transforms that make all code slower