From a4a055d286864babfc36f69f18d6d5629190b56e Mon Sep 17 00:00:00 2001 From: Scott Pritchard Date: Fri, 8 Mar 2024 23:33:19 +0000 Subject: [PATCH 1/2] Update native-modules-android.md Updated the documentation regarding adding packages to MainApplication.kt, so that they are consistent with https://reactnative.dev/docs/native-components-android Further reasoning: The method listed in the pre-commit version did not correctly register modules in my testing, but the version in the proposed change does appear to work as expected --- docs/native-modules-android.md | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/docs/native-modules-android.md b/docs/native-modules-android.md index 722a05ed130..cb93a1f381f 100644 --- a/docs/native-modules-android.md +++ b/docs/native-modules-android.md @@ -291,12 +291,9 @@ Locate ReactNativeHost’s `getPackages()` method and add your package to the pa ```kotlin -override fun getPackages(): List = - PackageList(this).packages.apply { - // Packages that cannot be autolinked yet can be added manually here, for example: - // packages.add(new MyReactNativePackage()); - add(MyAppPackage()) - } +override fun getPackages() = PackageList(this).packages.apply { + add(MyAppPackage()) +} ``` From 051c026fb5daee4f7b475a69a9f7dd66f2f4c16a Mon Sep 17 00:00:00 2001 From: Scott Pritchard Date: Mon, 11 Mar 2024 15:46:08 +0000 Subject: [PATCH 2/2] Consistent docs on android native modules (MainApplication.kt changes) --- docs/native-components-android.md | 9 ++++++--- docs/native-modules-android.md | 9 ++++++--- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/docs/native-components-android.md b/docs/native-components-android.md index 38e478e803d..0e089050bae 100644 --- a/docs/native-components-android.md +++ b/docs/native-components-android.md @@ -795,9 +795,12 @@ public class MyPackage implements ReactPackage { ```kotlin title="MainApplication.kt" - override fun getPackages() = PackageList(this).packages.apply { - add(MyPackage()) - } + override fun getPackages(): List = + PackageList(this).packages.apply { + // Packages that cannot be autolinked yet can be added manually here, for example: + // add(MyReactNativePackage()); + add(MyAppPackage()) + } ``` diff --git a/docs/native-modules-android.md b/docs/native-modules-android.md index cb93a1f381f..37692bbdbfc 100644 --- a/docs/native-modules-android.md +++ b/docs/native-modules-android.md @@ -291,9 +291,12 @@ Locate ReactNativeHost’s `getPackages()` method and add your package to the pa ```kotlin -override fun getPackages() = PackageList(this).packages.apply { - add(MyAppPackage()) -} +override fun getPackages(): List = + PackageList(this).packages.apply { + // Packages that cannot be autolinked yet can be added manually here, for example: + // add(MyReactNativePackage()); + add(MyAppPackage()) + } ```