Skip to content

Commit 8ea8dd6

Browse files
dulmandakhhramos
authored andcommitted
deprecate ReactFragmentActivity (#19741)
Summary: Android Support Library page says https://developer.android.com/topic/libraries/support-library/ > Caution: Starting with Support Library release 26.0.0 (July 2017), the minimum supported API level across most support libraries has increased to Android 4.0 (API level 14) for most library packages. For more information, see Version Support and Package Names in this document. _android.support.v4.app.FragmentActivity_ is used to support **Fragment**s on Android API versions below 11. Now, we support only API version 14 and above, it's ok to remove _ReactFragmentActivity_ that extends _FragmentActivity_. Once ReactFragmentActivity removed, we can remove some codes that use _android.support.v4_ to work support _ReactFragmentActivity_ on **unsupported** Android versions. CI is failing for unknown reasons: https://circleci.com/gh/dulmandakh/react-native/278 > Received 'killed' signal Everything will build and work just fine, except showing _ ReactFragmentActivity_ as deprecated Closes #19741 Differential Revision: D8454968 Pulled By: hramos fbshipit-source-id: e5f901438ef764163af013fe854904a28c73070a
1 parent b4b0610 commit 8ea8dd6

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

ReactAndroid/src/main/java/com/facebook/react/ReactFragmentActivity.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,11 @@
1919
import com.facebook.react.modules.core.PermissionListener;
2020

2121
/**
22-
* Base Activity for React Native applications. Like {@link ReactActivity} but extends
23-
* {@link FragmentActivity} instead of {@link android.app.Activity}.
22+
* @deprecated
23+
* ReactFragmentActivity will be removed in 0.57 release.
24+
* Use {@link ReactActivity} instead.
2425
*/
26+
@Deprecated
2527
public abstract class ReactFragmentActivity extends FragmentActivity implements
2628
DefaultHardwareBackBtnHandler, PermissionAwareActivity {
2729

0 commit comments

Comments
 (0)