Skip to content

Commit c19bc0b

Browse files
cortinicofacebook-github-bot
authored andcommitted
Do not fail if -javadoc.jar are missing in the final NPM package (#33869)
Summary: Pull Request resolved: #33869 When I disabled the Javadoc pubblication as it was failing on CI, I forgot to turn off the verification that the -javadoc artifact is included inside the NPM package. This caused `build_npm_package-1` to fail on main. I'm fixing it here. Changelog: [Internal] [Fixed] - Do not fail if -javadoc.jar are missing in the final NPM package Reviewed By: cipolleschi Differential Revision: D36507320 fbshipit-source-id: 3836de5212de91bb44e0e586564b46114ca346b4
1 parent e584fd1 commit c19bc0b

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

scripts/publish-npm.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ if (isCommitly) {
170170
}
171171
}
172172

173-
// -------- Generating Android Artifacts with JavaDoc
173+
// -------- Generating Android Artifacts
174174
if (exec('./gradlew :ReactAndroid:installArchives').code) {
175175
echo('Could not generate artifacts');
176176
exit(1);
@@ -195,8 +195,6 @@ let artifacts = [
195195
'-release.aar',
196196
'-debug-sources.jar',
197197
'-release-sources.jar',
198-
'-debug-javadoc.jar',
199-
'-release-javadoc.jar',
200198
].map(suffix => {
201199
return `react-native-${releaseVersion}${suffix}`;
202200
});

0 commit comments

Comments
 (0)