Clean up some of the ReactNative Buck rules

mzlee · facebook-github-bot · commit dcf3cbeb3134 · 2017-03-23T12:02:25.000-07:00
Reviewed By: yangchi

Differential Revision: D4739284

fbshipit-source-id: 0ee335df0d114631e5fc60d5d6e51547e5312d39
diff --git a/ReactAndroid/src/main/jni/first-party/fbgloginit/BUCK b/ReactAndroid/src/main/jni/first-party/fbgloginit/BUCK
@@ -1,3 +1,5 @@
+include_defs("//ReactCommon/DEFS")
+
 cxx_library(
     name = "fbgloginit",
     srcs = [
@@ -14,6 +16,6 @@ cxx_library(
     visibility = ["PUBLIC"],
     xcode_public_headers_symlinks = True,
     deps = [
-        "//xplat/third-party/glog:glog",
+        GLOG_DEP,
     ],
 )
diff --git a/ReactCommon/DEFS b/ReactCommon/DEFS
@@ -0,0 +1,3 @@
+# Set up common deps
+
+GLOG_DEP = "//ReactAndroid/build/third-party-ndk/glog:glog"
diff --git a/ReactCommon/microprofiler/BUCK b/ReactCommon/microprofiler/BUCK
@@ -1,3 +1,5 @@
+include_defs("//ReactCommon/DEFS")
+
 cxx_library(
     name = "microprofiler",
     srcs = [
@@ -14,12 +16,11 @@ cxx_library(
     ],
     force_static = True,
     header_namespace = "microprofiler",
-    labels = ["accounts_for_platform_and_build_mode_flags"],
     visibility = [
         "PUBLIC",
     ],
     xcode_public_headers_symlinks = True,
     deps = [
-        "//xplat/third-party/glog:glog",
+        GLOG_DEP,
     ],
 )

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+# Set up common deps`
	`2`	`+`
	`3`	`+GLOG_DEP = "//ReactAndroid/build/third-party-ndk/glog:glog"`