Add tight lineHeight descender example to TextExample.android.js#57223
Open
javache wants to merge 1 commit into
Open
Add tight lineHeight descender example to TextExample.android.js#57223javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
Summary: Adds a `gjpqy` example to the Text > lineHeight RNTester section that exercises `fontSize: 24, lineHeight: 24`. Pure example addition for the upcoming `CustomLineHeightSpan` descender-clipping fix, providing the surface for a jest-e2e screenshot regression test. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D108409230
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108409230. |
cortinico
approved these changes
Jun 16, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a
gjpqyexample to the Text > lineHeight RNTester section that exercisesfontSize: 24, lineHeight: 24. Pure example addition for the upcomingCustomLineHeightSpandescender-clipping fix, providing the surface for a jest-e2e screenshot regression test.Changelog:
[Internal]
Reviewed By: cortinico
Differential Revision: D108409230