Merge pull request #191 from clue-labs/trace

Fix invalid references in exception stack trace

Author: WyriHaximus

src/Query/RetryExecutor.php

@@ -56,11 +56,11 @@ public function tryQuery(Query $query, $retries)
 
                 // Exception trace arguments are not available on some PHP 7.4 installs
                 // @codeCoverageIgnoreStart
-                foreach ($trace as &$one) {
+                foreach ($trace as $ti => $one) {
                     if (isset($one['args'])) {
-                        foreach ($one['args'] as &$arg) {
+                        foreach ($one['args'] as $ai => $arg) {
                             if ($arg instanceof \Closure) {
-                                $arg = 'Object(' . \get_class($arg) . ')';
+                                $trace[$ti]['args'][$ai] = 'Object(' . \get_class($arg) . ')';
                             }
                         }
                     }

tests/Query/RetryExecutorTest.php

@@ -94,9 +94,12 @@ public function queryShouldStopRetryingAfterSomeAttempts()
             $exception = $reason;
         });
 
-        /** @var \RuntimeException $exception */
+        assert($exception instanceof \RuntimeException);
         $this->assertInstanceOf('RuntimeException', $exception);
         $this->assertEquals('DNS query for igor.io (A) failed: too many retries', $exception->getMessage());
+        $this->assertEquals(0, $exception->getCode());
+        $this->assertInstanceOf('React\Dns\Query\TimeoutException', $exception->getPrevious());
+        $this->assertNotEquals('', $exception->getTraceAsString());
     }
 
     /**