Fix bug when destroying pages. Also spec the Activity targets to track any future occurrence of this issue.

Author: jamesu

app/models/page.rb

@@ -1,7 +1,7 @@
 class Page < RoleRecord
-  has_many :notes, :dependent => :delete_all
-  has_many :dividers, :dependent => :delete_all
-  has_many :uploads, :dependent => :delete_all
+  has_many :notes, :dependent => :destroy
+  has_many :dividers, :dependent => :destroy
+  has_many :uploads, :dependent => :destroy
 
   has_many :slots, :class_name => 'PageSlot', :order => 'position ASC', :dependent => :delete_all
 

spec/models/activity_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+describe Activity do
+  describe "target when deleting objects" do
+    it "should still be valid when deleting core project objects" do
+      
+      project = Factory.create(:project)
+      Factory.create(:comment, :project => project)
+      Factory.create(:conversation, :project => project)
+      Factory.create(:task_list, :project => project)
+      Factory.create(:upload, :project => project)
+      page = Factory.create(:page, :project => project)
+      
+      note = page.build_note({:name => 'Office Ettiquete'}).tap do |n|
+        n.updated_by = project.user
+        n.save
+      end
+      divider = page.build_note({:name => 'Office Ettiquete'}).tap do |n|
+        n.updated_by = project.user
+        n.save
+      end
+      
+      Activity.count.should_not == 0
+      Activity.all.map{|a|a.target.nil?}.include?(true).should == false
+      
+      Person.destroy_all
+      Comment.destroy_all
+      Conversation.destroy_all
+      TaskList.destroy_all
+      Page.destroy_all
+      
+      Activity.all.map{|a|a.target.nil?}.include?(true).should == false
+    end
+  end
+end