address review comments

Author: richm

roles/remediate/tasks/leapp_cgroups-v1_enabled.yml

@@ -26,7 +26,7 @@
       block:
         - name: leapp_cgroups-v1_enabled | Show the remediation command
           ansible.builtin.debug:
-            msg: "{{ leapp_inhibitor_remediation.context | join(' ') }}"
+            var: leapp_inhibitor_remediation.context | join(' ')
 
         - name: leapp_cgroups-v1_enabled | Update the kernel arguments to disable the cgroups-v1 in favor of cgroups-v2
           ansible.builtin.command:
@@ -37,6 +37,6 @@
 
         - name: leapp_cgroups-v1_enabled | Show the remediation command result
           ansible.builtin.debug:
-            msg: "{{ leapp_disable_cgroupsv1.stdout_lines }}"
+            msg: leapp_disable_cgroupsv1.stdout_lines
 
 ...

roles/remediate/tasks/leapp_deprecated_sshd_directive.yml

@@ -27,12 +27,15 @@
       block:
         - name: leapp_deprecated_sshd_directive | Output command to be executed
           ansible.builtin.debug:
-            msg: "{{ remediation.context | join(' ') }}"
+            var: remediation.context | join(' ')
 
         - name: leapp_deprecated_sshd_directive | Execute the remediation command - remove the deprecated directives from the sshd configuration
           ansible.builtin.command:
             argv: "{{ remediation.context }}"
           register: remediation_command_output
           changed_when: remediation_command_output is success
 
+        - name: leapp_deprecated_sshd_directive | Show remediation command output
+          debug:
+            var: remediation_command_output.stdout_lines
 ...

roles/remediate/tasks/leapp_legacy_network_configuration.yml

@@ -28,7 +28,7 @@
       block:
         - name: leapp_legacy_network_configuration | Show the remediation command
           ansible.builtin.debug:
-            msg: "{{ leapp_inhibitor_remediation.context | join(' ') }}"
+            var: leapp_inhibitor_remediation.context | join(' ')
 
         - name: leapp_legacy_network_configuration | Migrate the network connection configuration to the keyfile format
           ansible.builtin.command:
@@ -38,6 +38,6 @@
 
         - name: leapp_legacy_network_configuration | Show the remediation command result
           ansible.builtin.debug:
-            msg: "{{ leapp_legacy_network_config_migration.stdout_lines }}"
+            var: leapp_legacy_network_config_migration.stdout_lines
 
 ...

roles/remediate/tasks/leapp_missing_yum_plugins.yml

@@ -20,7 +20,7 @@
 
     - name: leapp_missing_yum_plugins | Output command to be executed
       ansible.builtin.debug:
-        msg: "{{ remediation.context | join(' ') }}"
+        msg: remediation.context | join(' ')
       when: remediation | length > 0
 
     - name: leapp_missing_yum_plugins | Execute the remediation command - remove the deprecated directives from the sshd configuration
@@ -30,4 +30,7 @@
       register: remediation_command_output
       changed_when: remediation_command_output is success
 
+    - name: leapp_missing_yum_plugins | Show remediation command output
+      debug:
+        var: remediation_command_output.stdout_lines
 ...

roles/remediate/tasks/leapp_nfs_detected.yml

@@ -34,13 +34,6 @@
           loop: "{{ split_summary }}"
           when: "'- NFS shares currently mounted:' in item"
 
-        # TODO: This is not used.  Remove it?  Does it have side effects?
-        - name: leapp_nfs_detected | Get systemd_mounts
-          ansible.builtin.set_fact:
-            systemd_mounts: "{{ item | split('- NFS mounts configured with systemd-mount:') | last | trim | regex_findall('- ([^ ]+)', '\\1') }}"
-          loop: "{{ split_summary }}"
-          when: "'- NFS mounts configured with systemd-mount:' in item"
-
         - name: leapp_nfs_detected | Comment NFS shares in /etc/fstab
           loop: "{{ fstab_entries }}"
           ansible.builtin.shell: |