#2579 RPK updates for changes to RP Connect commands#598
Merged
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Jeffail
reviewed
Jul 19, 2024
| [,bash] | ||
| ---- | ||
| rpk connect -c ./root_config.yaml streams` | ||
| rpk connect -c ./root_config.yaml streams |
There was a problem hiding this comment.
Suggested change
| rpk connect -c ./root_config.yaml streams | |
| rpk connect streams -o ./root_config.yaml |
Jeffail
reviewed
Jul 25, 2024
|
|
||
| ```bash | ||
| rpk connect -c target.yaml lint | ||
| rpk connect lint -c target.yaml |
There was a problem hiding this comment.
Suggested change
| rpk connect lint -c target.yaml | |
| rpk connect lint target.yaml |
| |=== | ||
| |*Value* |*Type* |*Description* | ||
|
|
||
| |--config, -c |- | Path to a configuration file. |
JakeSCahill
reviewed
Jul 26, 2024
Contributor
JakeSCahill
left a comment
JakeSCahill
left a comment
There was a problem hiding this comment.
These docs are autogenerated. Have these changes been made in the rpk source code?
Contributor
Author
|
Jeffail
approved these changes
Jul 26, 2024
JakeSCahill
approved these changes
Jul 26, 2024
Feediver1
added a commit
that referenced
this pull request
May 22, 2026
mfernest is no longer at the company; @Feediver1 (Joyce) is taking over to land this PR. Two outstanding items from the prior review pass: 1. Add --resources, -r to rpk-connect-streams.adoc flag table. Ben Barkhouse's original Slack report (cited in DOC-1970) called out this missing flag specifically. Sibling pages rpk-connect-lint.adoc and rpk-connect-run.adoc both already document --resources, -r; the flag is supported on streams mode too. Inserted in alphabetical order between --prefix-stream-endpoints and --help, -h, with the imperative-voice wording that matches the rest of the streams flag table. This closes Ben's first reported gap (the -o flag, his second concern, was already fixed in PR #598). 2. Restore the word 'first' to the rpk-connect-agent-run.adoc description, per @kbatuigas's suggestion in the original review. The 'first ... then' pair makes the sequence (read resource definitions, then run the agent) explicit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves https://github.com/redpanda-data/documentation-private/issues/2579
Review deadline: 12 July
Page previews
rpk connect
rpk connect echo
rpk connect lint
rpk connect streams
Checks