Skip to content

Commit 57fac33

Browse files
committed
add explanations
1) add explanations as to why software SPIs are selected 2) remove unused flag/option
1 parent 3e2a515 commit 57fac33

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

Marlin/src/HAL/HAL_LPC1768/spi_pins.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@
2727

2828
#if MB(MKS_SBASE)
2929

30-
#define LPC_SOFTWARE_SPI
30+
#define LPC_SOFTWARE_SPI // MKS_SBASE needs a software SPI because the
31+
// selected pins are not on a hardware SPI controller
3132

3233
// A custom cable is needed. See the README file in the
3334
// Marlin\src\config\examples\Mks\Sbase directory
@@ -39,7 +40,10 @@
3940

4041
#else
4142

42-
#define LPC_SOFTWARE_SPI
43+
#define LPC_SOFTWARE_SPI // Re-ARM board needs a software SPI because using the
44+
// standard LCD adapter results in the LCD and the
45+
// SD card sharing a single SPI when the RepRap Full
46+
// Graphic Smart Controller is selected
4347

4448
/** onboard SD card */
4549
//#define SCK_PIN P0_07
@@ -63,9 +67,5 @@
6367
#define SDSS SS_PIN
6468
#endif
6569

66-
#if defined(TARGET_LPC1768) && !defined(LPC_SOFTWARE_SPI) // signal LCDs that they need to use the hardware SPI
67-
#define SHARED_SPI
68-
#endif
69-
7070
#endif // MKS_SBASE
7171
#endif /* SPI_PINS_LPC1768_H */

0 commit comments

Comments
 (0)