Skip to content

Commit a2f3c74

Browse files
authored
Making the google-cloud setup.py valid. (googleapis#3358)
Also making sure that it gets checked on builds.
1 parent 0164a4e commit a2f3c74

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

.circleci/config.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,10 @@ jobs:
133133
if [[ -n $(grep vision ~/target_packages) ]]; then
134134
nox -f vision/nox.py
135135
fi
136+
- run:
137+
name: Make sure google-cloud setup.py is valid
138+
command: |
139+
nox -e lint_setup_py
136140
- deploy:
137141
name: Update the docs
138142
command: nox -e docs

README.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,9 @@ Contributing
131131

132132
Contributions to this library are always welcome and highly encouraged.
133133

134-
See `CONTRIBUTING`_ for more information on how to get started.
134+
See the `CONTRIBUTING doc`_ for more information on how to get started.
135135

136-
.. _CONTRIBUTING: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/CONTRIBUTING.rst
136+
.. _CONTRIBUTING doc: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/CONTRIBUTING.rst
137137

138138
Community
139139
---------
@@ -148,9 +148,9 @@ channel, click here to `get an invitation`_.
148148
License
149149
-------
150150

151-
Apache 2.0 - See `LICENSE`_ for more information.
151+
Apache 2.0 - See `the LICENSE`_ for more information.
152152

153-
.. _LICENSE: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/LICENSE
153+
.. _the LICENSE: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/LICENSE
154154

155155
.. |circleci| image:: https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python.svg?style=shield
156156
:target: https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python

0 commit comments

Comments
 (0)