implement compile_protoquil#15
Merged
Merged
Conversation
MarquessV
requested review from
Shadow53 and
notmgsk
and removed request for
notmgsk
Shadow53
reviewed
Dec 1, 2022
| let mut compiled_program: quil_program = std::ptr::null_mut(); | ||
|
|
||
| unsafe { | ||
| quilc_compile_protoquil.unwrap()(program.0, chip.0, &mut compiled_program); |
Contributor
There was a problem hiding this comment.
Can this fail? Is there an errno we should be checking or anything?
Contributor
There was a problem hiding this comment.
Good point to bring up. I wondered about this while writing the original bindings, and, IIRC, you do get back an error but there isn't much context to go along with it. One of those things that needs improving on the quil-lang side.
Contributor
Author
There was a problem hiding this comment.
Yeah, what Mark said. The error is a generic ERROR_FAIL message. Implementation here. We could implement it in all the methods now, but seems better to revisit when we actually get some real errors back from the lib side.
notmgsk
approved these changes
Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7
I also tried to see if I could find a workaround for #12 but I don't think it's possible without changing libquilc.