Skip to content

Commit 7c1b965

Browse files
authored
doc: fix various typos and documentation issues (#5771)
BUILDING.md: fix formatting and path typo gdb.md: fix multiple grammatical errors and typos siol.md: fix spelling errors rzshell.md: fix grammar debug-internals.md: remove internal notes and references to missing files
1 parent 6dd0dba commit 7c1b965

File tree

5 files changed

+22
-23
lines changed

5 files changed

+22
-23
lines changed

BUILDING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ If Rizin was installed using `meson`, you can run the following command from the
255255
same build directory where you had previously installed Rizin:
256256

257257
```
258-
$ sudo ninja -C uninstall # `sudo` may not be required based on how you configured the `build` directory with meson the first time```
258+
$ sudo ninja -C uninstall # `sudo` may not be required based on how you configured the `build` directory with meson the first time
259259
```
260260

261261
Furthermore, if you had installed Rizin using a distribution package, use the
@@ -273,7 +273,7 @@ $ sudo ninja -C build install # or `sudo meson install -C build`. `sudo` may not
273273

274274
If you are a developer, it might not be necessary to run the `install` step
275275
(the second step from above) every time you build Rizin. You can directly use
276-
`rizin` from `./build/binrz/rizin/rizin.`
276+
`rizin` from `./build/binrz/rizin/rizin`
277277

278278
If you encounter issues while re-building Rizin, try to remove the existing
279279
build directory (e.g. `rm -r ./build`) and clean the subproject files

doc/debug-internals.md

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,9 @@ example, spawning processes under a debugger.
2424
## librz/reg
2525

2626
The "reg" module provides functionality for reading and writing registers as
27-
well as setting up profiles. (??profiles??)
27+
well as setting up profiles.
2828

2929
The functionality lives in the following files:
30-
(?? why so many files? can this be simplified??)
3130

3231
librz/reg/arena.c // ?? used by analysis and debugger
3332
librz/reg/cond.c // condition registers
@@ -50,11 +49,11 @@ Rizin supports a multitude of different types of breakpoints.
5049
(`??` is there a list? sw, hw, and trace? anything else??)
5150

5251
librz/bp/bp.c // main breakpoint management code
53-
librz/bp/io.c // setting and resetting(??) breakpoints
54-
librz/bp/parser.h // header for breakpoint parser (??)
55-
librz/bp/parser.c // code for breakpoint parser (??)
52+
librz/bp/io.c // setting and resetting breakpoints
53+
librz/bp/parser.h // header for breakpoint parser
54+
librz/bp/parser.c // code for breakpoint parser
5655
librz/bp/plugin.c // breakpoint plugin management
57-
librz/bp/traptrace.c // traptrace (??)
56+
librz/bp/traptrace.c // traptrace
5857
librz/bp/watch.c // watch points (mostly not implemented)
5958

6059
For architecture specific-handling, "bp" delegates various functionality to
@@ -76,9 +75,9 @@ The main top-level debugger functionality lives here. It aims to abstract away
7675
the common code flow and integration into Rizin while delegating more nuanced
7776
system interactions to plug-ins.
7877

79-
librz/debug/arg.c // used by the analysis engine (??)
78+
librz/debug/arg.c // used by the analysis engine
8079
librz/debug/desc.c // code for handling file descriptors inside an inferior
81-
librz/debug/esil.c // ESIL related debugging code (??)
80+
librz/debug/esil.c // ESIL related debugging code
8281
librz/debug/map.c // top-level API for dealing with memory maps
8382
librz/debug/pid.c // top-level API for dealing with processes
8483
librz/debug/plugin.c // top-level debugger plugin API handling
@@ -160,7 +159,7 @@ following files:
160159
librz/debug/p/native/linux/linux_debug.c // main linux-specific debugging code
161160
librz/debug/p/native/linux/linux_debug.h // including cute penguin ascii art
162161

163-
// architecture-specific register handling on Linux (?? what is this format??)
162+
// architecture-specific register handling on Linux
164163
librz/debug/p/native/linux/reg/linux-arm.h
165164
librz/debug/p/native/linux/reg/linux-arm64.h
166165
librz/debug/p/native/linux/reg/linux-mips.h
@@ -180,13 +179,13 @@ following files:
180179
librz/debug/p/native/maps/darwin.c // platform-specific memory map handling
181180
librz/debug/p/native/xnu/xnu_debug.c // main XNU-specific debugging code
182181
librz/debug/p/native/xnu/xnu_debug.h // including cute apple ascii art
183-
librz/debug/p/native/xnu/trap_arm.c // ARM family hardware bps (??)
184-
librz/debug/p/native/xnu/trap_x86.c // x86 family hardware bps (??)
182+
librz/debug/p/native/xnu/trap_arm.c // ARM family hardware bps
183+
librz/debug/p/native/xnu/trap_x86.c // x86 family hardware bps
185184
librz/debug/p/native/xnu/xnu_excthreads.c // additional XNU thread handling
186185
librz/debug/p/native/xnu/xnu_threads.c // XNU thread and register handling
187186
librz/debug/p/native/xnu/xnu_threads.h
188187

189-
// architecture-specific register handling on XNU (?? what is this format??)
188+
// architecture-specific register handling on XNU
190189
librz/debug/p/native/xnu/reg/darwin-x86.h
191190
librz/debug/p/native/xnu/reg/darwin-arm.h
192191
librz/debug/p/native/xnu/reg/darwin-ppc.h
@@ -202,17 +201,17 @@ following files:
202201

203202
A debugger plug-in that enables debugging code natively on QNX systems. Corresponding
204203
IO plugin is located in librz/io/p/io_qnx.c
205-
See doc/qnx
204+
<!-- TODO: Add qnx documentation -->
206205

207206
### librz/debug/p/debug_rap.c
208207

209-
See doc/rap
208+
<!-- TODO: Add rap documentation -->
210209

211210
### librz/debug/p/debug_winkd.c
212211

213212
A debugger plugin that enables debugging code remotely via WinDbg protocol.
214213
WinDbg protocol parser is located in subprojects/rzwinkd. Corresponding IO
215-
plugin located in librz/io/p/io_winkd.c See doc/winkd.
214+
plugin located in librz/io/p/io_winkd.c <!-- TODO: Add winkd documentation -->
216215

217216
## Conclusion
218217

doc/gdb.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Connecting from rizin
1515

1616
Supported implementations
1717
=========================
18-
rizin have support for connecting to remote GDB instances:
18+
rizin has support for connecting to remote GDB instances:
1919

2020
x86-32 x86-64 arm arm64 sh
2121
winedbg x x - - -
@@ -45,7 +45,7 @@ Supported Commands
4545
The second one is the G packet, that writes the whole register Profile at once.
4646
The implementation first tries to use the newer P packet and if it receives a $00# packet (that says not implemented), it tries to write through the G packet.
4747

48-
- stepping (but this is still the softstep mode and for an unknown reason it sill does not call th gdb_write_register function)
48+
-- stepping (but this is still the softstep mode and for an unknown reason it still does not call the gdb_write_register function)
4949

5050
Supported Packets:
5151

@@ -60,7 +60,7 @@ TODO
6060
----
6161

6262
- Implement GDBserver to allow other apps use rizin debugger
63-
- Fix that usese the gdb internal stepping version
63+
- Fix that uses the gdb internal stepping version
6464
- Fix softstep, that it finally recoils correct (it just have to reset the eip/rip)
6565
- Add Breakpoints (should be an easy add of the function, because its already implemented in the gdb lib)
6666

doc/rzshell.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ Let's make an example and suppose we want to add the `sky` command, which
5050
would find all occurrences of the word "sky" in a binary. The first thing to
5151
do is to see where `sky` command could be added by reading
5252
[`librz/core/cmd_descs/cmd_descs.yaml`](https://github.com/rizinorg/rizin/blob/6f40dfe493f0caf9e0541e1ee83e3d8012b5750f/librz/core/cmd_descs/cmd_descs.yaml).
53-
`sky` is `s` command's subcommand and they are splitted and placed inside the .YAML
53+
`sky` is `s` command's subcommand and they are split and placed inside the .YAML
5454
file specified by the descriptor `subcommands` of the respective command. Since `sky`
5555
starts with an `s`, its subcommands would be in [`librz/core/cmd_descs/cmd_seek.yaml`](https://github.com/rizinorg/rizin/blob/6f40dfe493f0caf9e0541e1ee83e3d8012b5750f/librz/core/cmd_descs/cmd_seek.yaml).
5656
That file respects the same tree structure used when executing rizin and seeing its help,

doc/siol.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Mapping information in the map:
3434

3535
Section Transformation
3636
----------------------
37-
atm there are 3 diffent transformation-targets:
37+
atm there are 3 different transformation-targets:
3838

3939
- Hexeditor
4040
- Analysis
@@ -73,5 +73,5 @@ Emulation-Transformation:
7373

7474
- when the section does not allow write-access perform Analysis-Transformation, and you're done
7575
- open a new desc with write-permissions, using the malloc-plugin, with the size of vsize
76-
- copy min (size, vsize) bytes fram the desc, that fd referes to, starting at addr, to the new desc, starting at 0x0
76+
- copy min (size, vsize) bytes from the desc, that fd refers to, starting at addr, to the new desc, starting at 0x0
7777
- create a map with the size of vsize, that maps the new desc to vaddr, starting at 0x0

0 commit comments

Comments
 (0)