Merge pull request react-component#86 from react-component/fix/aria-expanded

afc163 · web-flow · commit 4d25f0a4133d · 2018-05-10T13:47:52.000+08:00
fix(WAI-ARIA): make aria-expanded prop valid in preact
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,6 +1,10 @@
 # History
 ----
 
+## 1.9.1 2018-05-10
+
+- Fix invalid aria-expanded prop in preact
+
 ## 1.9.0 2018-04-02
 
 - Add keyboard support [#84](https://github.com/react-component/collapse/pull/84)
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "rc-collapse",
-  "version": "1.9.0",
+  "version": "1.9.1",
   "description": "rc-collapse ui component for react",
   "keywords": [
     "react",
diff --git a/src/Panel.jsx b/src/Panel.jsx
@@ -49,7 +49,7 @@ class CollapsePanel extends Component {
           onClick={this.handleItemClick}
           role={accordion ? 'tab' : 'button'}
           tabIndex={disabled ? -1 : 0}
-          aria-expanded={isActive}
+          aria-expanded={`${isActive}`}
           onKeyPress={this.handleKeyPress}
         >
           {showArrow && <i className="arrow" />}

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "rc-collapse",`
`3`		`- "version": "1.9.0",`
	`3`	`+ "version": "1.9.1",`
`4`	`4`	`"description": "rc-collapse ui component for react",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"react",`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ class CollapsePanel extends Component {`
`49`	`49`	`onClick={this.handleItemClick}`
`50`	`50`	`role={accordion ? 'tab' : 'button'}`
`51`	`51`	`tabIndex={disabled ? -1 : 0}`
`52`		`- aria-expanded={isActive}`
	`52`	+ aria-expanded={`${isActive}`}
`53`	`53`	`onKeyPress={this.handleKeyPress}`
`54`	`54`	`>`
`55`	`55`	`{showArrow && <i className="arrow" />}`