Get coverage near 100% fix bugs

Author: robottaway

README.md

@@ -6,6 +6,23 @@ prompt unuo to checkout the required Git repo and using the Dockerfile make a
 container. If you like it can push the container on build to a Docker registry.
 
 
+# Install
+
+Installing is pretty simple:
+
+1. make a virtual environment and activate it
+1. ```pip install -r requirements.txt```
+
+
+# Running
+
+To run the app ```python unuo/app.py```
+
+
 # Unit Tests
 
-python setup.py test
+First install dependencies: ```pip install -r requirements_test.txt```
+
+To run the unit tests: ```python setup.py test```
+
+or if you want to run them and get test coverage: ```./coverage.sh```

tests/basic.py

@@ -10,6 +10,7 @@ def test_get_logger(self):
         import logging
         import tempfile
         import shutil
+        import os
 
         logs_folder = tempfile.mkdtemp()
         logmanager = FileLoggerManager(logs_folder)
@@ -18,6 +19,8 @@ def test_get_logger(self):
         l = logmanager.get_logger(build)
 
         # check that folder named test exists in temp folder
+        huh = os.path.exists(logs_folder)
+        self.assertTrue(huh)
 
         # check that there is one file handler
         handlers = l.handlers
@@ -39,3 +42,11 @@ def test_close_handlers(self):
         l = logsmanager.get_logger(build)
         logsmanager.close_handlers(l)
         shutil.rmtree(logs_folder)
+
+    def test_api_error(self):
+        from unuo.errors import ApiError
+        error = ApiError('ooops', 200)
+        d = error.to_dict()
+        self.assertIsNotNone(d)
+        j = error.to_json()
+        self.assertIsNotNone(j)

tests/unuo_tests.py

@@ -45,6 +45,12 @@ def test_profiles(self):
         self.assertTrue('dockertag' in j)
         self.assertTrue('push' in j)
 
+        # Get all profiles
+        rv = self.app.get('/profile')
+        self.assertEquals(200, rv.status_code)
+        j = json.loads(rv.data)
+        self.assertEquals(1, len(j['builds']))
+
         # Get the profile
         rv = self.app.get('/profile/test')
         self.assertEquals(200, rv.status_code)
@@ -53,7 +59,18 @@ def test_profiles(self):
         self.assertTrue('dockertag' in j)
         self.assertTrue('push' in j)
 
-        # Run a build (mock out docker commands)
+        # Get a non-existing profile
+        rv = self.app.get('/profile/nope')
+        self.assertEquals(404, rv.status_code)
+
+        # Run a build
         rv = self.app.post('/build/test')
         self.assertEquals(200, rv.status_code)
         self.assertTrue('line1' in rv.data)
+
+        # Post bad profile
+        rv = self.app.post(
+            '/profile/ooops',
+            data=json.dumps(dict(joe='shmoe')),
+            content_type='application/json')
+        self.assertEquals(400, rv.status_code)

unuo/errors.py

@@ -11,14 +11,14 @@ class ApiError(Exception):
     """
     code = 400
 
-    def __init__(self, description, code=None, payload=None):
+    def __init__(self, description, code=None):
         Exception.__init__(self)
         self.description = description
         if code is not None:
             self.code = code
 
     def to_dict(self):
-        return {'message': self.description, 'status_code': self.status_code}
+        return {'message': self.description, 'status_code': self.code}
 
     def to_json(self):
         return json.dumps(self.to_dict())

unuo/filebackend.py

@@ -65,7 +65,6 @@ def get_all_profiles(self):
         builds = []
         for phile in listdir(self.builds_folder):
             fp = os.path.join(self.builds_folder, phile)
-            if not os.path.isfile(fp):
-                continue
-            builds.append(phile)
+            if os.path.isfile(fp):
+                builds.append(phile)
         return builds