Allows "as <CustomType>" in parameter and return type declarations#262
Merged
TwitchBronBron merged 10 commits intorokucommunity:masterfrom Jan 12, 2021
Merged
Conversation
Collaborator
Author
|
I updated the PR with your comments - I also realized typings on class fields weren't being verified.. Not sure If i'm doing that correctly or not.... Namespaces are still not correctly checked though. :( |
Member
|
@elsassph I'd appreciate your thoughts on this PR. |
markwpearce
commented
Jan 7, 2021
Collaborator
Author
|
This now works with namespaces! This would be valid Brighterscript code: Vehicles.bs: namespace Vehicles
class Car
end class
class MonsterTruck
function driveOver(automobile as Car) as Trash.SquashedCar
return new Trash.SquashedCar()
end function
end class
end namespaceTrash.bs namespace Trash
class SquashedCar
end class
end namespace |
39c11f3 to
14aca9f
Compare
…fying CustomTypes on class fields
b692f03 to
c2cf523
Compare
Collaborator
Author
|
@TwitchBronBron - I think everything you brought up has been addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think this works yet "inside" a namespace...