This repository was archived by the owner on Aug 4, 2021. It is now read-only.
Support a namedExports false option for dataToEsm - #32
Merged
Conversation
lukastaegert
approved these changes
May 21, 2018
lukastaegert
left a comment
lukastaegert
left a comment
Member
There was a problem hiding this comment.
Just a minor comment, looks good!
| const n = options.compact ? '' : '\n'; | ||
| const declarationType = options.preferConst ? 'const' : 'var'; | ||
|
|
||
| if (options.namedExports === false || typeof data !== 'object' || Array.isArray(data)) |
Member
There was a problem hiding this comment.
If we actually allow for non-object types to be passed here, we should add a check for null as well.
Contributor
Author
|
Thanks @lukastaegert. Sure, I've pushed the update. Please also check the null PR here too. |
lukastaegert
approved these changes
May 21, 2018
lukastaegert
force-pushed
the
namedExports
branch
from
May 21, 2018 17:12
efa42bc to
eea7d7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for having a flag to entirely enable/disable named exports from data imports (currently named exports should be disabled for strict NodeJS compatibility with the work-in-progress implementation).