This repository was archived by the owner on Aug 4, 2021. It is now read-only.
Update micromatch dependency - #60
Merged
Merged
Conversation
Member
Author
|
And here we go, this would remove Node 6 compatibility. One advantage of moving it to the plugin context (i.e. |
lukastaegert
force-pushed
the
update-micromatch
branch
from
May 29, 2019 15:18
1d152ea to
5df5de4
Compare
Member
Author
|
Ok, so after some deliberation I decided the way forward is to bundle a Node 6 compatible version of micromatch with rollup-pluginutils (by means of transpiling it via the TypeScript compiler to ES2015). That way, we can guarantee compatibility across the ecosystem but profit from the better performance and reduced size. Especially Rollup itself will profit as it bundles this specific part of the pluginutils for some watch-mode features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first attempt at updating to the new micromatch 4. My fear is that this would be a breaking update as I think I have spotted some object rest/spread operators in its dependencies, but we will see what CI says on Node 6. Otherwise I wonder if we should consider moving the "createFilter" functionality to core Rollup (and make it throw if we are on a browser build) as there, we could use TypeScript to transpile the spread operators to something more downward compatible.