Allow ROOT_INCLUDE to specify standard library include paths#113
Conversation
There was a problem hiding this comment.
We try to layer ROOT on top of cling, as cleanly as possible. Thus cling should use ROOT_INCLUDE. Can we maybe adjust the interpreter construction instead, passing -isystem and -nostdinc++? Then cling could skip the stdinc++ determination, reacting on -nostdinc++ being passed as an argument.
There was a problem hiding this comment.
That would be great and makes much more sense indeed.
Is it something that is already implemented or does it need to be?
There was a problem hiding this comment.
Handling of -isystem should exist; skipping the gcc invocation if -nostdinc++ is passed or the ROOT part of the compiler includes do not exist.
There was a problem hiding this comment.
It works properly indeed.
Here is the new version : Y--@39736e1
|
Thank you for your PR! Nice ideas, let's get this in! Please let me know if one of my comments wasn't precise enough or misunderstood your patch. |
|
Thanks for your quick review! |
|
@Y-- - no need for an extra PR for cling! We will apply the changes from ROOT's cling to the cling repo. |
|
@Y-- Indeed, last of -O3 -O0 wins. |
There was a problem hiding this comment.
Oups, I forgot to remove that. It's not used indeed.
Removed here : Y--@83e6fc7
|
Awesome! Thank you so much :-) |
This way we do not need g++ at runtime