Skip to content

Surround lambda by appropriate preprocessor guards#13073

Merged
hahnjo merged 1 commit into
root-project:masterfrom
hahnjo:unused-lambda
Jun 22, 2023
Merged

Surround lambda by appropriate preprocessor guards#13073
hahnjo merged 1 commit into
root-project:masterfrom
hahnjo:unused-lambda

Conversation

@hahnjo
Copy link
Copy Markdown
Member

@hahnjo hahnjo commented Jun 22, 2023

... to avoid an unused-but-set-variable warning on Linux.

@hahnjo
Surround lambda by appropriate preprocessor guards
de50126 
... to avoid an unused-but-set-variable warning on Linux.
@hahnjo hahnjo requested a review from bellenot June 22, 2023 12:16
@hahnjo hahnjo self-assigned this Jun 22, 2023
@hahnjo hahnjo marked this pull request as ready for review June 22, 2023 12:16
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 22, 2023

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14
How to customize builds

This was referenced Jun 22, 2023
Merged
Merged
Merged
bellenot
bellenot approved these changes Jun 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jonas!

@hahnjo hahnjo mentioned this pull request Jun 22, 2023
Merged
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 22, 2023

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

@hahnjo hahnjo mentioned this pull request Jun 22, 2023
Closed
@hahnjo
Copy link
Copy Markdown
Member Author

hahnjo commented Jun 22, 2023

Linux and macOS passed in the new CI, and Windows passed on Jenkins (plus some Linux and macOS builds), so I'm going to merge this slightly early to avoid the annoying warning.

@hahnjo hahnjo merged commit 8d5eac9 into root-project:master Jun 22, 2023
@hahnjo hahnjo deleted the unused-lambda branch June 22, 2023 14:41
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 22, 2023

Build failed on mac12arm/cxx20.
Running on macphsft26.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2023-06-22T15:17:51.246Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 22, 2023

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2023-06-22T15:25:06.912Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1142 (message):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bellenot bellenot bellenot approved these changes

@Axel-Naumann Axel-Naumann Awaiting requested review from Axel-Naumann

@pcanal pcanal Awaiting requested review from pcanal pcanal is a code owner

Assignees

@hahnjo hahnjo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hahnjo @phsft-bot @bellenot