Do not allow short reads.#135
Closed
bbockelm wants to merge 1 commit into
Closed
Conversation
Contributor
|
Hi Brian, Thanks for the patch. I think the length returned by Read in ReadBuffer(char *,Int_t) should also be checked too, so I'll also change as well a adding your patch. These changes are in the older xroot plugin. In the newer plugin, TNetXNGFile, the Read() result is checked for a bad status, and the status of the individual chunks from VectorRead() are also checked. A length mismatch is a part of the validity check in the client, so short reads shouldn't be possible there. |
Contributor
|
Beg your pardon; there is a possibility of a short read in TNetXNGFile::Read(char*,Long64_t,Int_t). I will also add a check here. |
Contributor
|
Hi. I've added the patch. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for https://sft.its.cern.ch/jira/browse/ROOT-3341
@smithdh - can you review?