[CMake] Append to CMAKE_INSTALL_RPATH with CACHE FORCE#19135
Merged
Conversation
Correctly append the additional RPATHs set by the ROOT build system to the `CMAKE_INSTALL_RPATH` variable set by the user, which is cached in `CMAKE_INSTALL_RPATH-CACHED` by the ROOT build system. Follows up on c77bd87. Closes root-project#19134. Needs a backport to 6.36.
1 task
bellenot
approved these changes
Jun 23, 2025
Test Results 20 files 20 suites 3d 22h 9m 14s ⏱️ Results for commit 90f5a4c. |
Member
|
Thanks for these changes! |
pcanal
reviewed
Jun 23, 2025
ferdymercury
added a commit
to ferdymercury/root
that referenced
this pull request
Jun 24, 2025
cherry picked from root-project#19135
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly append the additional RPATHs set by the ROOT build system to the
CMAKE_INSTALL_RPATHvariable set by the user, which is cached inCMAKE_INSTALL_RPATH-CACHEDby the ROOT build system.Follows up on c77bd87.
Closes #19134.
Needs a backport to 6.36.