[CMake] Append to CMAKE_INSTALL_RPATH without force-overriding cache.#19500
Closed
hageboeck wants to merge 1 commit into
Closed
[CMake] Append to CMAKE_INSTALL_RPATH without force-overriding cache.#19500hageboeck wants to merge 1 commit into
hageboeck wants to merge 1 commit into
Conversation
It's preferable not to touch any cache variables, as they are user-settable (and can be altered after configuring). Given that RootBuildOptions is included at the outermost scope, it's sufficient to declare a new variable with the same name as the cache.
Contributor
|
I also have an alternative solution that avoids messing around with the |
Test Results 20 files 20 suites 3d 3h 51m 26s ⏱️ Results for commit 5ad21d5. |
Member
Author
|
Closing in favour of #19501 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@guitargeek, I would like to suggest this small change for #19135.
It's preferable not to touch any cache variables, as they are user-settable (and can be altered after configuring). Given that RootBuildOptions is included at the outermost scope, it's sufficient to declare a new variable with the same name as the cache.
On each CMake run, this variable will be recomputed from the cache variable + whatever we append, leaving the CMakeCache.txt invariant.
I also took the opportunity to clarify what the
rpathoption does, since this was not really explained (see e.g. #19327).