Always add -Wl,-rpath to output of root-config --libs#19951
Merged
Conversation
Follows up on 26d24de, where the `rpath` configuration path was made the default and can't be disabled anymore. This means that the `rpath` CMake configuration option is gone, but there was still some code that checked it, which I missed to update. Addresses root-project#19501 (comment).
Test Results 20 files 20 suites 3d 8h 22m 36s ⏱️ For more details on these failures, see this check. Results for commit 8d0486f. |
hageboeck
approved these changes
Sep 23, 2025
Member
hageboeck
left a comment
hageboeck
left a comment
There was a problem hiding this comment.
LGTM, even if I can't guarantee that it covers all cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on 26d24de, where the
rpathconfiguration path was made the default and can't be disabled anymore.This means that the
rpathCMake configuration option is gone, but there was still some code that checked it, which I missed to update.Addresses #19501 (comment).