[Minuit2] Use signed integer as index variable in OpenMP 'for' statement#20587
Merged
Conversation
Compiling Minuit2 with `minuit2_omp=ON` when using MVSC raises `error C3016: 'i': index variable in OpenMP 'for' statement must have signed integral type` Source of the error is line 102 in `math/minuit2/src/Numerical2PGradientCalculator.cxx` where (in commit 95035e2) the for-loop variable type was changed from integer to unsigned integer. While this is no problem for GCC, MVSC apparently strictly forbids this. Closes root-project#20586.
1 task
Test Results 22 files 22 suites 3d 19h 59m 28s ⏱️ For more details on these failures, see this check. Results for commit 6a1e86e. |
hageboeck
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling Minuit2 with
minuit2_omp=ONwhen using MVSC raiseserror C3016: 'i': index variable in OpenMP 'for' statement must have signed integral typeSource of the error is line 102 in
math/minuit2/src/Numerical2PGradientCalculator.cxxwhere (in commit 95035e2) the for-loop variable type was changed from integer to unsigned integer. While this is no problem for GCC, MVSC apparently strictly forbids this.Closes #20586.