Skip to content

[hist] extend LIST option to support CONT1 CONT2 CONT3#20884

Merged
dpiparo merged 1 commit into
root-project:masterfrom
ferdymercury:patch-20
Jan 20, 2026
Merged

[hist] extend LIST option to support CONT1 CONT2 CONT3#20884
dpiparo merged 1 commit into
root-project:masterfrom
ferdymercury:patch-20

Conversation

@ferdymercury
Copy link
Copy Markdown
Collaborator

@ferdymercury ferdymercury commented Jan 14, 2026

This Pull request:

Changes or fixes:

fyi @bgrube

Fixes #20858

Follow-up of d4b273b

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@couet
Copy link
Copy Markdown
Member

couet commented Jan 14, 2026

The LIST option retrieves the contours generated by the CONT0 option. I am not sure the other algorithms work the same way as CONTO and therefore the contours might not be generated as CONTO does it.

@ferdymercury
Copy link
Copy Markdown
Collaborator Author

ferdymercury commented Jan 14, 2026

I verified that it works with this test script:

   auto c1 = new TCanvas("c1","c1",600,400);
   auto hcont1 = new TH2F("hcont1","Option CONT1Z LIST example ",40,-4,4,40,-20,20);
   float px, py;
   for (Int_t i = 0; i < 25000; i++) {
      gRandom->Rannor(px,py);
      hcont1->Fill(px-1,5*py);
      hcont1->Fill(2+0.5*px,2*py-10.,0.1);
   }
   hcont1->Draw("CONT1Z LIST");
   gPad->Update();
   new TCanvas();
    ((TGraph*)((TList*)((TObjArray*)gROOT->GetListOfSpecials()->FindObject("contours"))->At(0))->First())->Draw("AL");
image

Copy link
Copy Markdown
Member

@couet couet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok LGTM

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 14, 2026

Test Results

    23 files      23 suites   3d 21h 35m 9s ⏱️
 3 813 tests  3 813 ✅ 0 💤 0 ❌
80 376 runs  80 376 ✅ 0 💤 0 ❌

Results for commit 4dc9352.

♻️ This comment has been updated with latest results.

@ferdymercury ferdymercury requested a review from dpiparo January 18, 2026 15:43
@ferdymercury
Copy link
Copy Markdown
Collaborator Author

gentle ping (CI is green, good to merge from my side)

@dpiparo dpiparo merged commit fd3cd40 into root-project:master Jan 20, 2026
53 of 55 checks passed
@dpiparo
Copy link
Copy Markdown
Member

dpiparo commented Jan 20, 2026

thanks. I am preparing the backports.

@hageboeck
Copy link
Copy Markdown
Member

gentle ping (CI is green, good to merge from my side)

Sorry, it took super long because there were lots of CI instabilities in the past days. Had nothing to do with the PR, but wanted to be super sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make "LIST" draw option for contour plot work with "CONT1", "CONT2", and "CONT3" options

4 participants