[core] do not assert when casting huge enum uint64_t into int64_t

[ferdymercury]

This Pull request:

Changes or fixes:

even if it becomes negative due to the overflow.

Fixes #17697

Tested that the Python reproducer in #17697 no longer crashes

code = """
struct Foo
{
  enum E {
    BIG = ((unsigned long long)1)<<63
  };
};
"""

import ROOT
ROOT.gInterpreter.Declare (code)

f = ROOT.Foo()
f.BIG
(Foo::E::Foo::E::BIG) : (internal_enum_type_t) -9223372036854775808

Checklist:

• tested changes locally
• updated the docs (if necessary)

[pcanal]

I suppose this is an okay solution. It would be even better if we could return the correct value (would likely require more significant changes)

[dpiparo]

Do we maybe need a unit test for this?

[github-actions]

Test Results

    22 files      22 suites   3d 15h 46m 38s ⏱️
 3 812 tests  3 811 ✅ 0 💤 1 ❌
76 720 runs  76 719 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 8da579a.

♻️ This comment has been updated with latest results.

[dpiparo]

I added a test and restarted the builds. Let's see how builds go and then we can merge.

[ferdymercury]

test seems to fail on Windows. Maybe internal_enum_type_t has a different size on Windows?

[dpiparo]

2 commits were fused to ease future bisects.