[638][io] use UUIDv4 in ROOT files#22063
Merged
Merged
Conversation
(cherry picked from commit 7865c27)
(cherry picked from commit e9292b8)
(cherry picked from commit 14491a8)
Use UUIDv4 in TDirectory (hence in TDirectoryFile and TFile) and in the RMiniFile. Note that TDirectory is used without gSystem (needed for GetCryptoRandom()) in the context of rootcling. In principle, GetCryptoRandom() should work without a TSystem object. That may be for a later commit. The UUIDv4, unlike the current UUIDv1, is (with high enough probability) globally unique. (cherry picked from commit b387638)
Factor out calling the OS crypto random number generator into a free function in the Base package. In turn, TSystem::GetCryptoRandom() can be static and does not rely in gSystem being initialized. (cherry picked from commit f20d779)
(cherry picked from commit 019f4e7)
Test Results 19 files 19 suites 3d 2h 55m 1s ⏱️ Results for commit 14894f7. |
jblomer
approved these changes
Apr 25, 2026
Contributor
jblomer
left a comment
jblomer
left a comment
There was a problem hiding this comment.
Thanks! So once resolved for 6.38, the bot can use that to apply the correct changes to 6.36? That's nice!
dpiparo
merged commit 8c4b972
into
root-project:v6-38-00-patches
28 of 29 checks passed
Member
Author
|
I hope so... |
Member
Author
|
/backport to 6.36 |
|
Preparing to backport PR #22063 to branch 6.36 requested by dpiparo |
|
This PR has been backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BP of #22035 (by hand, some conflicts needed resolution). To be automatically backported to 6.36.