Test coverage for TBufferFileRead#1
Closed
bbockelm wants to merge 47 commits into
Closed
Conversation
…nction returning short
…(with -Dminimal=ON root is not build).
This reverts commit 1f3175d. corresponding fix in ROOT is not yet complete.
…ed code, so use an indirect marker
And add slight variation of the unnamed macro detection
…>/map<int> to function properly
…Edit. See ROOT-8048
Adopt the file used for the prefetch test to make sure that buffering is actually storing to local disk.
Member
|
Just to let you know that I'm aware of the missing mirror updates; I will do it "soon" - it has a dedicated slot on my priority list :-) |
Contributor
Author
|
Closing this PR as it got a bit messy in the transition of |
Axel-Naumann
added a commit
that referenced
this pull request
May 5, 2022
… issue: This causes failures with ``` #0 0xb6e5c7e3 in std::_Head_base<0u, std::thread::id const&, false>::_M_head (__b=...) at /usr/include/c++/8/tuple:160 #1 0xb6e5c7cb in std::_Tuple_impl<0u, std::thread::id const&>::_M_head (__t=...) at /usr/include/c++/8/tuple:351 #2 0xb6e5d488 in std::__get_helper<0u, std::thread::id const&> (__t=...) at /usr/include/c++/8/tuple:1304 #3 0xb6e5d462 in std::get<0u, std::thread::id const&> (__t=std::tuple containing = {...}) at /usr/include/c++/8/tuple:1315 #4 0xb6e5d4ad in std::pair<std::thread::id const, unsigned int>::pair<std::thread::id const&, 0u>(std::tuple<std::thread::id const&>&, std::tuple<>&, std::_Index_tuple<0u>, std::_Index_tuple<>) (this=0xa48005e0, __tuple1=std::tuple containing = {...}, __tuple2=empty std::tuple) at /usr/include/c++/8/tuple:1667 #5 0xb6e5c863 in std::pair<std::thread::id const, unsigned int>::pair<std::thread::id const&>(std::piecewise_construct_t, std::tuple<std::thread::id const&>, std::tuple<>) (this=0xa48005e0, __first=<error reading variable: Cannot access memory at address 0x7c>, __second=empty std::tuple) at /usr/include/c++/8/tuple:1657 #6 0xaf853abc in ?? () #7 0xb7722fd2 in start_thread (arg=<optimized out>) at pthread_create.c:486 #8 0xb76386d6 in clone () at ../sysdeps/unix/sysv/linux/i386/clone.S:108 ``` Note esp the JIT frame, and the broken parameter address 0x7c, signaling an ABI issue. When running this test compiled (root.exe ....C+) the test passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides simple test coverage for TBufferFileRead (root PR #146), adopted from the
prefetchingtest.NOTE: there are quite a few commits associated with this PR because it appears mirroring of the
roottestrepository broke at the end of January. If we fix the mirroring, github should figure out the correct commits.