Skip to content

json: replace TRef class by TNamed class in testing#146

Merged
pcanal merged 1 commit into
root-project:masterfrom
linev:json_tref
Mar 16, 2018
Merged

json: replace TRef class by TNamed class in testing#146
pcanal merged 1 commit into
root-project:masterfrom
linev:json_tref

Conversation

@linev
Copy link
Copy Markdown
Member

@linev linev commented Mar 15, 2018

TRef has custom streamer and not correctly supported by JSON I/O

TRef has custom streamer and not correctly supported by JSON I/O
@phsft-bot
Copy link
Copy Markdown

Starting build on centos7/gcc49, mac1013/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu16/native, ubuntu16/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link
Copy Markdown

Build failed on slc6/gcc62.
See console output.

Warnings:

  • ninja: warning: multiple rules generate tutorials/hsimple.root. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn]

Failing tests:

@pcanal
Copy link
Copy Markdown
Member

pcanal commented Mar 16, 2018

Note that this does not solve the problem seen in roottest-root-io-json as the problem is actually that sometimes some elements of the vector are mis-detected as being allocated by TObject::operator new (because the memory allocated by the vector happens to be filled with the magic pattern TObject::operator new).

https://epsft-jenkins.cern.ch/job/root-nightly-master/BUILDTYPE=Release,COMPILER=native,LABEL=mac1012/1657/testReport/projectroot.roottest.root.io/json/roottest_root_io_json_make/

@pcanal
Copy link
Copy Markdown
Member

pcanal commented Mar 16, 2018

However since json-io does not yet fully support TRef, I am merging this nonetheless.

@pcanal pcanal merged commit 8f75c55 into root-project:master Mar 16, 2018
@linev linev deleted the json_tref branch March 19, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants