Update README for Ros2 (#17)#18
Conversation
|
@nfry321 FYI, I retargeted this to the |
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Thanks for the PR! Overall, I really like the explanation of the topics, parameters, and launch file parameters. I've left a bunch of improvements inline. Once those are fixed, I think this is good to go in.
| @@ -1,4 +1,70 @@ | |||
| teleop_twist_joy [](https://travis-ci.org/ros-teleop/teleop_twist_joy) | |||
| ros2/teleop_twist_joy [](https://travis-ci.org/ros-teleop/teleop_twist_joy) | |||
There was a problem hiding this comment.
The link to the travis job here is wrong. I think we should just remove the link completely, since we don't use travis on this repository at all.
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
|
No problem, thanks for tidying those issues, they should now have been changed. |
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Looks good, thanks for the contribution.
The PR jobs are failing, but there is no way it can be because of this PR, so I'm going to go ahead and merge anyway.
2 participants
No description provided.