Update README to reflect changes to config parameters. (fixes #23)#24
Merged
Conversation
That works for me.
Looks good to me as well.
I think it is clear enough.
I honestly don't have a strong opinion here. ROS 2 code tends to favor RPY over YPR, but that is not universal. In this case, I'd say leave it as-is.
Personally, I don't think so. RPY seems pretty clear, there is a strong backwards compatibility argument, and I'd rather not add aliases unless we have a very strong reason. |
clalancette
approved these changes
Jan 11, 2021
clalancette
left a comment
There was a problem hiding this comment.
Thanks so much for the changes! I'm going to go ahead and merge this as it is an obvious improvement. Please feel free to keep commenting or open a new issues for further problems you find.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have updated the README to reflect the new parameters, and the new defaults.
In doing so a few issues arose, some of which I have acted on and some I have left.
axis(to refer to motion/coordinate axes as well as joystick axes). I think this is an inevitable consequence of a program that maps from axis to axis, and is clear enough from context.roll,pitch,yawrather thanyaw,pitch,roll. I presume this has arisen from the original one only havingxandyaw, and the other axes being added later. But now that we can map to all six axes, it seems confusing to me that the order here is different from the order that you then see in theTwistmessage. I've opted not to change this yet in case there is a strong convention to favouryaw,pitch,rollthat is more important, but if you agree then I'll reverse them.x/y/z? I'm not sure what is clearer/more sensible.