feat: support 16kb page sizes#66
Merged
Merged
Conversation
Reviewer's GuideModernizes the React Native example app and Android plugin configuration to align with React Native 0.76 and newer Android/Kotlin/Gradle tooling, updates the Rownd Android SDK and serialization libs, and wires the example app to consume the local rownd_react-native module. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Raising
sourceCompatibility/targetCompatibilityto Java 21 inandroid/build.gradleis a big jump relative to typical React Native Android baselines; consider whether Java 17 (or matching the minimum required by AGP/RN) would be safer for consumers of this library. - The example app and the library Gradle properties now use different SDK levels (example targets/compiles 35 while
RowndPlugin_targetSdkVersionis 34); it may be worth aligning these to avoid subtle behavior differences between the example and consuming apps.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Raising `sourceCompatibility`/`targetCompatibility` to Java 21 in `android/build.gradle` is a big jump relative to typical React Native Android baselines; consider whether Java 17 (or matching the minimum required by AGP/RN) would be safer for consumers of this library.
- The example app and the library Gradle properties now use different SDK levels (example targets/compiles 35 while `RowndPlugin_targetSdkVersion` is 34); it may be worth aligning these to avoid subtle behavior differences between the example and consuming apps.
## Individual Comments
### Comment 1
<location> `android/gradle.properties:3` </location>
<code_context>
-RowndPlugin_ndkversion=21.4.7075529
+RowndPlugin_kotlinVersion=2.0.21
+RowndPlugin_minSdkVersion=26
+RowndPlugin_targetSdkVersion=34
+RowndPlugin_compileSdkVersion=35
+RowndPlugin_ndkversion=26.1.10909125
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Plugin targetSdkVersion is behind the example app’s targetSdkVersion.
The example project now targets SDK 35 while `RowndPlugin_targetSdkVersion` is still 34. Please update this to 35 so the plugin is validated against the same (latest) target SDK as the host app and to reduce the risk of behavioral differences.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
The exclusionList function moved from a named export in metro-config to a default export at metro-config/src/defaults/exclusionList in newer Metro versions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update the Android plugin and React Native example app to current tooling and dependencies while wiring the library module into the example app.
Enhancements:
Build: